[PATCH 1/2] avformat/aeadec, avcodec/atrac1: Fix 8 and 4-channel ATRAC1 support
I'm sending the patch again, so that it is correctly rebased on the current master. Here are the two sample files required by the FATE test: https://0x0.st/Xaw2.aea/boxboy333_house_music_multitrack.aea https://0x0.st/Xaw_.pcm/boxboy333_house_music_multitrack.pcm Please let me know if I need to provide anything else.
asivery via ffmpeg-devel:
I'm sending the patch again, so that it is correctly rebased on the current master. Here are the two sample files required by the FATE test: https://0x0.st/Xaw2.aea/boxboy333_house_music_multitrack.aea https://0x0.st/Xaw_.pcm/boxboy333_house_music_multitrack.pcm Please let me know if I need to provide anything else.
Why such a gigantic file? And why actually a multi-channel file given that there are no special coding modes for multi-channel files? - Andreas
On Sat, 15 Jun 2024 I was asked for samples by Anton Khirnov - this is why I wrote the test. If the test is not necessary after all, that patch doesn't need to be applied. I can also shorten the test file, if it's required. On Wednesday, July 3rd, 2024 at 4:49 PM, Andreas Rheinhardt <andreas.rheinhardt@outlook.com> wrote:
asivery via ffmpeg-devel:
I'm sending the patch again, so that it is correctly rebased on the current master. Here are the two sample files required by the FATE test: https://0x0.st/Xaw2.aea/boxboy333_house_music_multitrack.aea https://0x0.st/Xaw_.pcm/boxboy333_house_music_multitrack.pcm Please let me know if I need to provide anything else.
Why such a gigantic file? And why actually a multi-channel file given that there are no special coding modes for multi-channel files?
- Andreas
_______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
Quoting Andreas Rheinhardt (2024-07-03 16:49:55)
asivery via ffmpeg-devel:
I'm sending the patch again, so that it is correctly rebased on the current master. Here are the two sample files required by the FATE test: https://0x0.st/Xaw2.aea/boxboy333_house_music_multitrack.aea https://0x0.st/Xaw_.pcm/boxboy333_house_music_multitrack.pcm Please let me know if I need to provide anything else.
Why such a gigantic file? And why actually a multi-channel file given that there are no special coding modes for multi-channel files?
In what world is this gigantic? I find your obsession with FATE sample sizes to be very counterproductive. Storage is cheap, developer time is not. -- Anton Khirnov
Pinging the patch. I've merged the fate test case patch into the functionality one, and rebased onto the current master. Here are the two sample files required by the FATE test: https://0x0.st/Xaw2.aea/boxboy333_house_music_multitrack.aea https://0x0.st/Xaw_.pcm/boxboy333_house_music_multitrack.pcmPlease let me know if I need to provide anything else.
On Sun, Sep 29, 2024 at 1:32 PM asivery via ffmpeg-devel <ffmpeg-devel@ffmpeg.org> wrote:
Pinging the patch. I've merged the fate test case patch into the functionality one, and rebased onto the current master. Here are the two sample files required by the FATE test: https://0x0.st/Xaw2.aea/boxboy333_house_music_multitrack.aea https://0x0.st/Xaw_.pcm/boxboy333_house_music_multitrack.pcm Please let me know if I need to provide anything else.
This patch looks good to me. Andreas, are you ok with the size of the reference file to add to the fate suite or do you still prefer it if it is reduced further?
participants (4)
-
Andreas Rheinhardt -
Anton Khirnov -
asivery -
Ramiro Polla