On 24 June 2010 13:46, Josh Allmann <joshua.allmann@gmail.com> wrote:
On 24 June 2010 12:53, Luca Barbato <lu_zero@gentoo.org> wrote:
On 06/24/2010 10:31 AM, Josh Allmann wrote:
On 24 June 2010 00:14, Martin Storsjö <martin@martin.st> wrote:
Except that, this looks good to me. Ronald, Luca, any other opinions, or is this good to go?
Sweeet. Updated patchset is properly numbered.
Two nits
0002
+ * MPEG-4 Video RTP callbacks.
Might be nice adding the rfc number there as well
Added reference to RFC 3016.
0004
+#include <strings.h>
string_s_ ?
Needed for strcasecmp, apparently. Also fixed a related issue; strings.h is now included in patch 003 rather than 004.
The minor indentation change Martin asked for in 002 somehow disappeared; patch re-done with this.
Josh