On Fri, Mar 28, 2008 at 09:20:05PM +0100, Bartlomiej Wolowiec wrote:
On czwartek, 27 marca 2008, Michael Niedermayer wrote:
You do this in stream_type but this name is totally wrong this is not a stream_type. It is not even constant for a stream. NEVER even think of using a name from the a52* spec, the people who wrote it are idiots. Its a flag indicating the start/end of a frame. And IMHO it should be returned more directly than as a context variable but thats rather minor the name is a major issue. It totally confused me until looked it up in the spec. [...] 2.change of stream_type to frame_type
According to your suggestion, I changed name of stream type to frame type. Should correction of type of frame_type from uint8_t to EAC3FrameType be in separate patch?
Index: libavcodec/ac3dec.c =================================================================== --- libavcodec/ac3dec.c (wersja 12621) +++ libavcodec/ac3dec.c (kopia robocza) @@ -1169,7 +1169,7 @@ case AC3_PARSE_ERROR_FRAME_SIZE: av_log(avctx, AV_LOG_ERROR, "invalid frame size\n"); break; - case AC3_PARSE_ERROR_STREAM_TYPE: + case AC3_PARSE_ERROR_FRAME_TYPE: av_log(avctx, AV_LOG_ERROR, "invalid stream type\n"); ^^^^^^
yes but thats minor ... [...] this would confuse people remainder of the patch looks ok [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I know you won't believe me, but the highest form of Human Excellence is to question oneself and others. -- Socrates