Re: [FFmpeg-soc] [PATCH] fixes for asrc_buffer
Some fixes to the asrc_buffer. Add config props since src filter has no inputs and default config props will fail. --- libavfilter/allfilters.c | 2 +- libavfilter/asrc_buffer.c | 10 ++++++++-- 2 files changed, 9 insertions(+), 3 deletions(-)
On date Saturday 2010-07-31 03:27:14 -0700, S.N. Hemanth Meenakshisundaram encoded:
Some fixes to the asrc_buffer. Add config props since src filter has no inputs and default config props will fail.
--- libavfilter/allfilters.c | 2 +- libavfilter/asrc_buffer.c | 10 ++++++++-- 2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/libavfilter/allfilters.c b/libavfilter/allfilters.c index 6a828fa..069c56c 100644 --- a/libavfilter/allfilters.c +++ b/libavfilter/allfilters.c @@ -60,7 +60,7 @@ void avfilter_register_all(void) REGISTER_FILTER (UNSHARP, unsharp, vf); REGISTER_FILTER (VFLIP, vflip, vf);
- REGISTER_FILTER (ABUFFER, abuffer, asrc); + REGISTER_FILTER (ABUFFER, buffer, asrc);
I suppose this hunk is wrong. [...] Regards.
On 07/31/2010 07:08 AM, Stefano Sabatini wrote:
On date Saturday 2010-07-31 03:27:14 -0700, S.N. Hemanth Meenakshisundaram encoded:
Some fixes to the asrc_buffer. Add config props since src filter has no inputs and default config props will fail.
--- libavfilter/allfilters.c | 2 +- libavfilter/asrc_buffer.c | 10 ++++++++-- 2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/libavfilter/allfilters.c b/libavfilter/allfilters.c index 6a828fa..069c56c 100644 --- a/libavfilter/allfilters.c +++ b/libavfilter/allfilters.c @@ -60,7 +60,7 @@ void avfilter_register_all(void) REGISTER_FILTER (UNSHARP, unsharp, vf); REGISTER_FILTER (VFLIP, vflip, vf);
- REGISTER_FILTER (ABUFFER, abuffer, asrc); + REGISTER_FILTER (ABUFFER, buffer, asrc);
I suppose this hunk is wrong.
This works because the file is currently named asrc_buffer.c while the string name of the filter is abuffer to avoid clashes with vsrc_buffer (which is called "buffer"). I guess this is inconsistent. I will rename asrc_buffer.* to asrc_abuffer if that's acceptable.
On date Saturday 2010-07-31 09:49:02 -0700, S.N. Hemanth Meenakshisundaram encoded:
On 07/31/2010 07:08 AM, Stefano Sabatini wrote:
On date Saturday 2010-07-31 03:27:14 -0700, S.N. Hemanth Meenakshisundaram encoded:
Some fixes to the asrc_buffer. Add config props since src filter has no inputs and default config props will fail.
--- libavfilter/allfilters.c | 2 +- libavfilter/asrc_buffer.c | 10 ++++++++-- 2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/libavfilter/allfilters.c b/libavfilter/allfilters.c index 6a828fa..069c56c 100644 --- a/libavfilter/allfilters.c +++ b/libavfilter/allfilters.c @@ -60,7 +60,7 @@ void avfilter_register_all(void) REGISTER_FILTER (UNSHARP, unsharp, vf); REGISTER_FILTER (VFLIP, vflip, vf);
- REGISTER_FILTER (ABUFFER, abuffer, asrc); + REGISTER_FILTER (ABUFFER, buffer, asrc);
I suppose this hunk is wrong.
This works because the file is currently named asrc_buffer.c while the string name of the filter is abuffer to avoid clashes with vsrc_buffer (which is called "buffer"). I guess this is inconsistent. I will rename asrc_buffer.* to asrc_abuffer if that's acceptable.
Ah OK, yes renaming the file would be good. Regards.
participants (2)
-
S.N. Hemanth Meenakshisundaram -
Stefano Sabatini