[PATCH] add sampling handling to theora depacketizer
This patch increases compatibility with the Theora spec by allowing the SDP to specify the sampling/pix_fmt. The sampling parameter is technically required by the spec, but the depacketizer still works fine if the SDP omits it. Josh
On Tue, 27 Jul 2010, Josh Allmann wrote:
This patch increases compatibility with the Theora spec by allowing the SDP to specify the sampling/pix_fmt. The sampling parameter is technically required by the spec, but the depacketizer still works fine if the SDP omits it.
You forgot to attach the patch... // Martin
On 27 July 2010 01:16, Martin Storsjö <martin@martin.st> wrote:
On Tue, 27 Jul 2010, Josh Allmann wrote:
This patch increases compatibility with the Theora spec by allowing the SDP to specify the sampling/pix_fmt. The sampling parameter is technically required by the spec, but the depacketizer still works fine if the SDP omits it.
You forgot to attach the patch...
Indeed.
On 07/27/2010 08:20 PM, Josh Allmann wrote:
+ } else { + av_log(codec, AV_LOG_ERROR, + "Unsupported pixel format %s\n", attr); + return AVERROR_INVALIDDATA;
why not return AVERROR_PATCHWELCOME; lu -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero
On 27 July 2010 13:35, Luca Barbato <lu_zero@gentoo.org> wrote:
On 07/27/2010 08:20 PM, Josh Allmann wrote:
+ } else { + av_log(codec, AV_LOG_ERROR, + "Unsupported pixel format %s\n", attr); + return AVERROR_INVALIDDATA;
why not return AVERROR_PATCHWELCOME;
The 3 formats I added should cover all legal cases. From Section 1 of the spec: Three different chroma subsampling formats are supported: 4:2:0, 4:2:2, and 4:4:4. The Theora I format does not support interlaced material, variable frame rates, bit-depths larger than 8 bits per component, nor alternate color spaces such as RGB or arbitrary multi-channel spaces.
On 07/27/2010 10:42 PM, Josh Allmann wrote:
The 3 formats I added should cover all legal cases. From Section 1 of the spec:
Ok then =) -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero
participants (3)
-
Josh Allmann -
Luca Barbato -
Martin Storsjö