[soc]: r4821 - in amr: amrnbfloatdata.h amrnbfloatdec.c
Author: cmcq Date: Tue Jul 28 18:17:23 2009 New Revision: 4821 Log: Don't include headers already included by libavutil/common.h Modified: amr/amrnbfloatdata.h amr/amrnbfloatdec.c Modified: amr/amrnbfloatdata.h ============================================================================== --- amr/amrnbfloatdata.h Tue Jul 28 18:14:29 2009 (r4820) +++ amr/amrnbfloatdata.h Tue Jul 28 18:17:23 2009 (r4821) @@ -30,7 +30,6 @@ #include <stdint.h> #include <stddef.h> -#include <math.h> #include "libavutil/common.h" Modified: amr/amrnbfloatdec.c ============================================================================== --- amr/amrnbfloatdec.c Tue Jul 28 18:14:29 2009 (r4820) +++ amr/amrnbfloatdec.c Tue Jul 28 18:17:23 2009 (r4821) @@ -26,15 +26,11 @@ */ -#include <math.h> #include <stddef.h> -#include <stdio.h> -#include <stdlib.h> #include "avcodec.h" #include "get_bits.h" #include "libavutil/common.h" -#include "internal.h" #include "celp_math.h" #include "celp_filters.h" #include "acelp_filters.h"
On Tue, Jul 28, 2009 at 06:17:23PM +0200, cmcq wrote:
Log: Don't include headers already included by libavutil/common.h
Why? I don't think this is a good idea. Diego
2009/7/28 Diego Biurrun <diego@biurrun.de>:
On Tue, Jul 28, 2009 at 06:17:23PM +0200, cmcq wrote:
Log: Don't include headers already included by libavutil/common.h
Why? I don't think this is a good idea.
Diego
I'm making sure each #include is justified - some of them were for functions that aren't used anymore. I'll have another go, trying not to rely on standard headers included by other headers.
On Wed, Jul 29, 2009 at 12:14:22AM +0100, Colin McQuillan wrote:
2009/7/28 Diego Biurrun <diego@biurrun.de>:
On Tue, Jul 28, 2009 at 06:17:23PM +0200, cmcq wrote:
Log: Don't include headers already included by libavutil/common.h
Why? I don't think this is a good idea.
I'm making sure each #include is justified - some of them were for functions that aren't used anymore. I'll have another go, trying not to rely on standard headers included by other headers.
Removing unused headers is OK, but headers required for things that are used should be #included directly IMO.
participants (3)
-
cmcq -
Colin McQuillan -
Diego Biurrun