August 2012 - FFmpeg-trac - lists.ffmpeg.org

#1485(avformat:new): Support for Quicktime CLEF/TAPT atoms
by FFmpeg 21 Dec '13

21 Dec '13

#1485: Support for Quicktime CLEF/TAPT atoms ----------------------------------+--------------------------------------- Reporter: brams | Type: enhancement Status: new | Priority: normal Component: avformat | Version: git-master Keywords: | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | ----------------------------------+--------------------------------------- FFmpeg does not currently support the Quicktime CLEF (Track Clean Aperture Dimensions) and TAPT (Track Aperture Mode Dimensions) atoms. (See https://developer.apple.com/library/mac/#documentation/QuickTime/QTFF/QTFFC…) These atoms are necessary for detecting the correct dimensions for some videos, since they take precedence in Quicktime over the normal TKHD (track header) width/height and over the track PASP (pixel aspect ratio). The attached patch adds support for these atoms. I can provide a sample video if desired. -- Ticket URL: <https://ffmpeg.org/trac/ffmpeg/ticket/1485> FFmpeg <http://ffmpeg.org> FFmpeg issue tracker

1 7

#1582(avfilter:new): Banding/discoloration in darker gradients when converting to rgb24
by FFmpeg 15 Dec '13

15 Dec '13

#1582: Banding/discoloration in darker gradients when converting to rgb24 ----------------------------------+--------------------------------------- Reporter: y3kcjd5 | Type: defect Status: new | Priority: normal Component: avfilter | Version: unspecified Keywords: win64 | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | ----------------------------------+--------------------------------------- Summary: I've discovered that when I'm converting videos to the rgb24 format (in attempting to use the libx264rgb codec) I get banding and discoloration in darker areas with (color) gradients. To eliminate the possibility that it was the codec (as opposed to the format filter) causing the problem, I did some tests converting the video to .png images. Specifically, I found that: yuv420p10le(source video) -- looks nice yuv420p10le -> rgb24 -- banding/discoloration yuv420p10le -> rgb48be -- looks nice yuv420p10le -> rgb48be -> rgb24 -- banding/discoloration yuv420p10le -> yuv420p -> rgb24 -- banding but no discoloration I assume that the banding in the yuv420p example is simply a result of the reduced colorspace, but I don't see why any of the other conversions should result in any visible changes. I'm using one of Zeranoe's windows builds (win7 64bit) so I don't know if this happens on Linux. Log file output for the yuv420p10le->rgb24 example follows: {{{ ffmpeg started on 2012-07-28 at 10:56:16 Report written to "ffmpeg-20120728-105616.log" Command line: ffmpeg -i vtst0.mp4 -map 0:0 -vsync 0 -report -filter:v "format=rgb24" "tst%03d.png" ffmpeg version N-42704-g85761ef Copyright (c) 2000-2012 the FFmpeg developers built on Jul 20 2012 20:39:19 with gcc 4.7.1 (GCC) configuration: --enable-gpl --enable-version3 --disable-w32threads --enable-runtime-cpudetect --enable-avisynth --enable-bzlib --enable- frei0r --enable-libass --enable-libcelt --enable-libopencore-amrnb --enable-libopencore-amrwb --enable-libfreetype --enable-libgsm --enable- libmp3lame --enable-libnut --enable-libopenjpeg --enable-librtmp --enable- libschroedinger --enable-libspeex --enable-libtheora --enable-libutvideo --enable-libvo-aacenc --enable-libvo-amrwbenc --enable-libvorbis --enable- libvpx --enable-libx264 --enable-libxavs --enable-libxvid --enable-zlib libavutil 51. 65.100 / 51. 65.100 libavcodec 54. 42.100 / 54. 42.100 libavformat 54. 18.100 / 54. 18.100 libavdevice 54. 1.100 / 54. 1.100 libavfilter 3. 2.100 / 3. 2.100 libswscale 2. 1.100 / 2. 1.100 libswresample 0. 15.100 / 0. 15.100 libpostproc 52. 0.100 / 52. 0.100 [mov,mp4,m4a,3gp,3g2,mj2 @ 00000000002e2ec0] Format mov,mp4,m4a,3gp,3g2,mj2 probed with size=2048 and score=100 [mov,mp4,m4a,3gp,3g2,mj2 @ 00000000002e2ec0] ISO: File Type Major Brand: isom [mov,mp4,m4a,3gp,3g2,mj2 @ 00000000002e2ec0] File position before avformat_find_stream_info() is 7074306 [h264 @ 00000000002f40a0] no picture [mov,mp4,m4a,3gp,3g2,mj2 @ 00000000002e2ec0] All info found rfps: 23.750000 0.011875 rfps: 23.833333 0.004757 rfps: 23.916667 0.000859 rfps: 24.000000 0.000180 rfps: 24.083333 0.002721 rfps: 24.166667 0.008482 rfps: 24.250000 0.017461 rfps: 47.666667 0.019029 rfps: 47.750000 0.009623 rfps: 47.833333 0.003436 rfps: 47.916667 0.000469 rfps: 48.000000 0.000722 rfps: 48.083333 0.004194 rfps: 48.166667 0.010885 rfps: 23.976024 0.000046 rfps: 47.952048 0.000183 [mov,mp4,m4a,3gp,3g2,mj2 @ 00000000002e2ec0] File position after avformat_find_stream_info() is 1243950 Input #0, mov,mp4,m4a,3gp,3g2,mj2, from 'vtst0.mp4': Metadata: major_brand : isom minor_version : 512 compatible_brands: isomiso2avc1mp41 encoder : Lavf54.18.100 Duration: 00:00:10.09, start: 0.000000, bitrate: 5607 kb/s Stream #0:0(und), 41, 1/1000: Video: h264 (High 10) (avc1 / 0x31637661), yuv420p10le, 1920x1080, 5604 kb/s, 23.98 fps, 23.98 tbr, 1k tbn, 47.95 tbc Metadata: handler_name : VideoHandler [buffer @ 0000000004ba0f20] Setting entry with key 'video_size' to value '1920x1080' [buffer @ 0000000004ba0f20] Setting entry with key 'pix_fmt' to value '72' [buffer @ 0000000004ba0f20] Setting entry with key 'time_base' to value '1/1000' [buffer @ 0000000004ba0f20] Setting entry with key 'pixel_aspect' to value '0/1' [buffer @ 0000000004ba0f20] Setting entry with key 'sws_param' to value 'flags=2' [buffer @ 0000000004ba0f20] Setting entry with key 'frame_rate' to value '24000/1001' [graph 0 input from stream 0:0 @ 0000000004d73980] w:1920 h:1080 pixfmt:yuv420p10le tb:1/1000 fr:24000/1001 sar:0/1 sws_param:flags=2 [Parsed_format_0 @ 0000000004d738e0] auto-inserting filter 'auto-inserted scaler 0' between the filter 'graph 0 input from stream 0:0' and the filter 'Parsed_format_0' [auto-inserted scaler 0 @ 0000000004d73b20] w:1920 h:1080 fmt:yuv420p10le sar:0/1 -> w:1920 h:1080 fmt:rgb24 sar:0/1 flags:0x4 [h264 @ 00000000002f40a0] detected 2 logical cores Output #0, image2, to 'tst%03d.png': Metadata: major_brand : isom minor_version : 512 compatible_brands: isomiso2avc1mp41 encoder : Lavf54.18.100 Stream #0:0(und), 0, 1/90000: Video: png, rgb24, 1920x1080, q=2-31, 200 kb/s, 90k tbn, 23.98 tbc Metadata: handler_name : VideoHandler Stream mapping: Stream #0:0 -> #0:0 (h264 -> png) Press [q] to stop, [?] for help [h264 @ 00000000003aa100] no picture DTS -42, next:-62146 st:0 invalid dropping [h264 @ 0000000004cdbf00] no picture frame= 3 fps=0.0 q=0.0 size= 0kB time=00:00:00.12 bitrate= 0.0kbits/s frame= 5 fps=3.1 q=0.0 size= 0kB time=00:00:00.20 bitrate= 0.0kbits/s frame= 7 fps=3.0 q=0.0 size= 0kB time=00:00:00.29 bitrate= 0.0kbits/s ... frame= 237 fps=2.6 q=0.0 size= 0kB time=00:00:09.88 bitrate= 0.0kbits/s No more inputs to read from, finishing. [output stream 0:0 @ 0000000004d73a00] EOF on sink link output stream 0:0:default. frame= 242 fps=2.6 q=0.0 Lsize= 0kB time=00:00:10.26 bitrate= 0.0kbits/s video:276218kB audio:0kB subtitle:0 global headers:0kB muxing overhead -100.000000% [AVIOContext @ 000000000216fd80] Statistics: 4336059 bytes read, 2 seeks }}} -- Ticket URL: <https://ffmpeg.org/trac/ffmpeg/ticket/1582> FFmpeg <http://ffmpeg.org> FFmpeg issue tracker

1 13

#43(undetermined:new): JACK input device doesn't link on OS X
by FFmpeg 10 Dec '13

10 Dec '13

#43: JACK input device doesn't link on OS X --------------------------+--------------------- Reporter: nieder | Type: defect Status: new | Priority: normal Component: undetermined | Version: git Keywords: | Blocked By: Blocking: | Reproduced: 0 Analyzed: 0 | --------------------------+--------------------- This is copied from the old roundup #976 https://roundup.libav.org/issue976 On OS X, using --enable-indev=jack, the build fails with {{{ CC libavdevice/jack_audio.o /src/ffmpeg/libavdevice/jack_audio.c: In function 'audio_read_packet': /src/ffmpeg/libavdevice/jack_audio.c:277: warning: implicit declaration of function 'sem_timedwait' AR libavdevice/libavdevice.a LD libavdevice/libavdevice.52.dylib Undefined symbols: "_sem_timedwait", referenced from: _audio_read_packet in jack_audio.o ld: symbol(s) not found collect2: ld returned 1 exit status make: *** [libavdevice/libavdevice.52.dylib] Error 1 }}} sem_* is semaphore_* on OS X. -- Ticket URL: <http://ffmpeg.org/trac/ffmpeg/ticket/43> FFmpeg <http://ffmpeg.org> FFmpeg issue tracker

1 6

#314(avdevice:new): OpenAL device does not work on OS X
by FFmpeg 10 Dec '13

10 Dec '13

#314: OpenAL device does not work on OS X ----------------------+-------------------------- Reporter: nieder | Type: enhancement Status: new | Priority: normal Component: avdevice | Version: git-master Keywords: | Blocked By: Blocking: | Reproduced: 0 Analyzed: 0 | ----------------------+-------------------------- configure is not set to find openal on OS X. The fix for the linker check is easy: add "-Wl,-framework,OpenAL" to the list of flags to check {{{ -enabled openal && { { for al_libs in "${OPENAL_LIBS}" "-lopenal" "-lOpenAL32"; do +enabled openal && { { for al_libs in "${OPENAL_LIBS}" "-lopenal" "-lOpenAL32" "-Wl,-framework,OpenAL"; do }}} I don't know how to fix the header check to look for multiple possibilities, but on OS X the header in the OpenAL framework is found in OpenAL/al.h (not AL/al.h like in linux). If I change the header check in configure and the includes in libavdevice/openal-dec.c, the build and linkage works well. However, running 'ffmpeg -f openal' as suggested in the manual fails with an malloc error, so this might just not be doable on OS X. {{{ nieder $ /usr/local/ffmpeg-git/bin/ffmpeg -list_devices true -f openal -i dummy out.ogg ffmpeg version N-31036-g65eae2a, Copyright (c) 2000-2011 the FFmpeg developers built on Jun 27 2011 10:29:19 with gcc 4.0.1 (Apple Inc. build 5493) configuration: --prefix=/usr/local/ffmpeg-git --mandir=/usr/local /ffmpeg-git/share/man --disable-static --enable-shared --enable-gpl --enable-version3 --enable-postproc --enable-pthreads --enable-x11grab --enable-bzlib --enable-libcelt --enable-libopencore-amrnb --enable- libopencore-amrwb --enable-libdirac --enable-libfreetype --enable- libmp3lame --enable-libopenjpeg --enable-librtmp --enable-libschroedinger --enable-libspeex --enable-libtheora --enable-libvorbis --enable-libvpx --enable-libx264 --enable-libxvid --enable-openal --enable-zlib --disable- debug --extra-cflags='-I/sw/lib/libspeex1/include -I/sw/include -I/usr/X11R6/include' --extra-ldflags='-L/sw/lib/libspeex1/lib -L/sw/lib -L/usr/X11R6/lib' libavutil 51. 10. 0 / 51. 10. 0 libavcodec 53. 7. 0 / 53. 7. 0 libavformat 53. 4. 0 / 53. 4. 0 libavdevice 53. 2. 0 / 53. 2. 0 libavfilter 2. 24. 0 / 2. 24. 0 libswscale 2. 0. 0 / 2. 0. 0 libpostproc 51. 2. 0 / 51. 2. 0 [openal @ 0x200a800] List of OpenAL capture devices on this system: [openal @ 0x200a800] Built-in Microphone dummy: Immediate exit requested nieder $ /usr/local/ffmpeg-git/bin/ffmpeg -f openal -i 'Built-in Microphone' out.ogg ffmpeg version N-31036-g65eae2a, Copyright (c) 2000-2011 the FFmpeg developers built on Jun 27 2011 10:29:19 with gcc 4.0.1 (Apple Inc. build 5493) configuration: --prefix=/usr/local/ffmpeg-git --mandir=/usr/local /ffmpeg-git/share/man --disable-static --enable-shared --enable-gpl --enable-version3 --enable-postproc --enable-pthreads --enable-x11grab --enable-bzlib --enable-libcelt --enable-libopencore-amrnb --enable- libopencore-amrwb --enable-libdirac --enable-libfreetype --enable- libmp3lame --enable-libopenjpeg --enable-librtmp --enable-libschroedinger --enable-libspeex --enable-libtheora --enable-libvorbis --enable-libvpx --enable-libx264 --enable-libxvid --enable-openal --enable-zlib --disable- debug --extra-cflags='-I/sw/lib/libspeex1/include -I/sw/include -I/usr/X11R6/include' --extra-ldflags='-L/sw/lib/libspeex1/lib -L/sw/lib -L/usr/X11R6/lib' libavutil 51. 10. 0 / 51. 10. 0 libavcodec 53. 7. 0 / 53. 7. 0 libavformat 53. 4. 0 / 53. 4. 0 libavdevice 53. 2. 0 / 53. 2. 0 libavfilter 2. 24. 0 / 2. 24. 0 libswscale 2. 0. 0 / 2. 0. 0 libpostproc 51. 2. 0 / 51. 2. 0 mpeg(49840,0xa025b720) malloc: *** error for object 0x1e2c0e0: incorrect checksum for freed object - object was probably modified after being freed. *** set a breakpoint in malloc_error_break to debug mpeg(49840,0xa025b720) malloc: *** error for object 0x1e2c0e0: incorrect checksum for freed object - object was probably modified after being freed. *** set a breakpoint in malloc_error_break to debug [openal @ 0x200a800] Error: ALC Invalid Device Bus error }}} -- Ticket URL: <http://ffmpeg.org/trac/ffmpeg/ticket/314> FFmpeg <http://ffmpeg.org> FFmpeg issue tracker

1 2

#228(FFserver:new): FFserver: reordering of "<Stream>"s in config file makes difference
by FFmpeg 10 Dec '13

10 Dec '13

#228: FFserver: reordering of "<Stream>"s in config file makes difference ------------------------+---------------------------------------- Reporter: burek | Owner: baptiste Type: defect | Status: new Priority: important | Component: FFserver Version: git | Keywords: ordering items config file Blocked By: | Blocking: Reproduced: 0 | Analyzed: 0 ------------------------+---------------------------------------- The first config file (ffserver1.conf) made ffserver drop rtsp connections, with error message "'''[NULL @ 0x1be7ba0]AAC with no global headers is currently not supported.'''" After just a simple reordering of <Stream> items (ffserver2.conf), everything started to work properly? Is this expected behavior? :) -- Ticket URL: <https://ffmpeg.org/trac/ffmpeg/ticket/228> FFmpeg <http://ffmpeg.org> FFmpeg issue tracker

1 6

#1578(undetermined:new): variable FPS incorrect frame length
by FFmpeg 10 Dec '13

10 Dec '13

#1578: variable FPS incorrect frame length -------------------------------------+------------------------------------- Reporter: kubabrecka | Type: defect Status: new | Priority: normal Component: | Version: undetermined | unspecified Keywords: | Blocked By: fps,framerate,vfr,qtrle | Reproduced by developer: 0 Blocking: | Analyzed by developer: 0 | -------------------------------------+------------------------------------- I have a sample video to reproduce this bug - see attachment. The video is in Apple Animation codec (qtrle) with variable frame rate and contains only 5 frames. Frames 1,2,4 and 5 are displayed for a very short time, but frame 3 is much longer. When I extract all the frames into PNGs with this command: ./ffmpeg -vsync 2 -i apple-animation-variable-fps-bug.mov -vf "[in]showinfo[out]" out/img%04d.png it's fine, I get 5 PNG files, and the timestamps shown on the output are correct: n:0 pts:0 pts_time:0 pos:48 n:1 pts:600 pts_time:0.2 pos:4335 n:2 pts:1300 pts_time:0.433333 pos:8286 n:3 pts:7300 pts_time:2.43333 pos:12518 n:4 pts:8100 pts_time:2.7 pos:16642 as you can see, frame n:2 (the third frame) is displayed for much longer than the others. However, when I run this command to dump the frames with a constant FPS: ./ffmpeg -i apple-animation-variable-fps-bug.mov -r 30 out/img%04d.png the frames are dumped with wrong timing. The "long" frame was 2 seconds long, so it should be in about 60 frames (with FPS 30), but instead it only gets 7 frames. But the next frame which should be very short is dumped into 60 frames. It seems that the conversion between variable FPS into constant FPS incorrectly assigns frame length into the next frame. -- Ticket URL: <https://ffmpeg.org/trac/ffmpeg/ticket/1578> FFmpeg <http://ffmpeg.org> FFmpeg issue tracker

1 10

#1603(undetermined:new): fix remuxing of ima_adpcm_qt in mov
by FFmpeg 09 Dec '13

09 Dec '13

#1603: fix remuxing of ima_adpcm_qt in mov -------------------------------------+------------------------------------- Reporter: ami_stuff | Owner: Type: defect | Status: new Priority: normal | Component: Version: | undetermined unspecified | Keywords: Blocked By: | Blocking: Reproduced by developer: 0 | Analyzed by developer: 0 -------------------------------------+------------------------------------- it looks like ffmpeg does not set correctly compression ID and stts_entries[i].duration while remuxing ima_adpcm_qt in mov, so the output file is unplayable by qt (and ffmpeg) attached hack fixes for me remuxing of ima_ffmpeg.mov {{{ C:\>ffmpeg -i ima_ffmpeg.mov -acodec copy out.mov ffmpeg version N-43160-g752344d Copyright (c) 2000-2012 the FFmpeg developers built on Aug 3 2012 02:38:06 with gcc 4.5.0 (GCC) 20100414 (Fedora MinGW 4.5. 0-1.fc14) configuration: --prefix=/var/www/users/research/ffmpeg/snapshots/build --arch= x86 --target-os=mingw32 --cross-prefix=i686-pc-mingw32- --cc='ccache i686 -pc-min gw32-gcc' --enable-w32threads --enable-memalign-hack --enable-runtime- cpudetect --enable-cross-compile --enable-static --disable-shared --extra- libs='-lws2_32 - lwinmm -lpthread' --extra-cflags='--static -I/var/www/users/research/ffmpeg/snap shots/build/include' --extra-ldflags='-static -L/var/www/users/research/ffmpeg/s napshots/build/lib' --enable-bzlib --enable-zlib --enable-gpl --enable- version3 --enable-nonfree --enable-libx264 --enable-libspeex --enable-libtheora --enable- libvorbis --enable-libfaac --enable-libxvid --enable-libopencore-amrnb --enable- libopencore-amrwb --enable-libmp3lame --enable-libvpx --disable- decoder=libvpx libavutil 51. 66.100 / 51. 66.100 libavcodec 54. 48.100 / 54. 48.100 libavformat 54. 22.100 / 54. 22.100 libavdevice 54. 2.100 / 54. 2.100 libavfilter 3. 5.101 / 3. 5.101 libswscale 2. 1.100 / 2. 1.100 libswresample 0. 15.100 / 0. 15.100 libpostproc 52. 0.100 / 52. 0.100 Guessed Channel Layout for Input Stream #0.0 : mono Input #0, mov,mp4,m4a,3gp,3g2,mj2, from 'ima_ffmpeg.mov': Metadata: major_brand : qt minor_version : 512 compatible_brands: qt encoder : Lavf54.22.100 Duration: 00:00:12.62, start: 0.000000, bitrate: 34 kb/s Stream #0:0(eng): Audio: adpcm_ima_qt (ima4 / 0x34616D69), 8000 Hz, mono, s1 6, 32 kb/s Metadata: handler_name : DataHandler Output #0, mov, to 'out.mov': Metadata: major_brand : qt minor_version : 512 compatible_brands: qt encoder : Lavf54.22.100 Stream #0:0(eng): Audio: adpcm_ima_qt (ima4 / 0x34616D69), 8000 Hz, mono, 32 kb/s Metadata: handler_name : DataHandler Stream mapping: Stream #0:0 -> #0:0 (copy) Press [q] to stop, [?] for help size= 53kB time=00:00:12.62 bitrate= 34.4kbits/s video:0kB audio:52kB subtitle:0 global headers:0kB muxing overhead 1.278610% }}} -- Ticket URL: <https://ffmpeg.org/trac/ffmpeg/ticket/1603> FFmpeg <http://ffmpeg.org> FFmpeg issue tracker

1 2

#998(undetermined:new): Must convert mms://... streams to mmsh://... for FFmpeg to work
by FFmpeg 09 Dec '13

09 Dec '13

#998: Must convert mms://... streams to mmsh://... for FFmpeg to work -------------------------------------+------------------------------------- Reporter: DonMoir | Type: defect Status: new | Priority: normal Component: | Version: undetermined | unspecified Keywords: | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | -------------------------------------+------------------------------------- This means anyone using mms streams must "discover" this. Using just mms://... this fails: '''ffplay mms://live1.wm.skynews.servecast.net/skynews_wmlz_live300k''' ffplay version N-37771-gfd0b8d5 Copyright (c) 2003-2012 the FFmpeg developers built on Feb 11 2012 13:42:37 with gcc 4.6.2 libavutil 51. 39.100 / 51. 39.100 libavcodec 54. 1.100 / 54. 1.100 libavformat 54. 0.100 / 54. 0.100 libavdevice 53. 4.100 / 53. 4.100 libavfilter 2. 62.100 / 2. 62.100 libswscale 2. 1.100 / 2. 1.100 libswresample 0. 6.100 / 0. 6.100 libpostproc 52. 0.100 / 52. 0.100 '''mms://live1.wm.skynews.servecast.net/skynews_wmlz_live300k: No such file or directory''' Changing it to mmsh://... works fine: ffplay mmsh://live1.wm.skynews.servecast.net/skynews_wmlz_live300k ffplay version N-37771-gfd0b8d5 Copyright (c) 2003-2012 the FFmpeg developers built on Feb 11 2012 13:42:37 with gcc 4.6.2 libavutil 51. 39.100 / 51. 39.100 libavcodec 54. 1.100 / 54. 1.100 libavformat 54. 0.100 / 54. 0.100 libavdevice 53. 4.100 / 53. 4.100 libavfilter 2. 62.100 / 2. 62.100 libswscale 2. 1.100 / 2. 1.100 libswresample 0. 6.100 / 0. 6.100 libpostproc 52. 0.100 / 52. 0.100 [wmv3 @ 014DD260] Extra data: 8 bits left, value: 0 [asf @ 00A4D8E0] Estimating duration from bitrate, this may be inaccurate Input #0, asf, from 'mmsh://live1.wm.skynews.servecast.net/skynews_wmlz_live300k': Metadata: title : Sky News artist : BSkyB copyright : BSkyB WMFSDKVersion : 11.0.5721.5145 WMFSDKNeeded : 0.0.0.0000 IsVBR : 0 Duration: N/A, start: 2308326.720000, bitrate: 252 kb/s Stream #0:0(eng): Audio: wmav2 (a[1][0][0] / 0x0161), 44100 Hz, 1 channels, s16, 32 kb/s Stream #0:1(eng): Video: wmv3 (Main) (WMV3 / 0x33564D57), yuv420p, 320x180, 220 kb/s, 25 tbr, 1k tbn, 1k tbc [wmv3 @ 014DD260] Extra data: 8 bits left, value: 0 -- Ticket URL: <https://ffmpeg.org/trac/ffmpeg/ticket/998> FFmpeg <http://ffmpeg.org> FFmpeg issue tracker

1 8

#512(avutil:new): libavutil\common.h conversion warnings
by FFmpeg 05 Dec '13

05 Dec '13

#512: libavutil\common.h conversion warnings ---------------------------------------+--------------------------------- Reporter: DonMoir | Owner: michael Type: enhancement | Status: new Priority: minor | Component: avutil Version: unspecified | Keywords: Blocked By: | Blocking: Reproduced by developer: 0 | Analyzed by developer: 0 ---------------------------------------+--------------------------------- Would you please make a couple minor changes to libavutil\common.h. static av_always_inline av_const int16_t av_clip_int16_c(int a) { if ((a+0x8000) & ~0xFFFF) return (a>>31) ^ 0x7FFF; else return a; } the returns cause me a conversion warning because they need to be cast to int16_t and so I have to change this each time I get a new include for ffmpeg. change to: static av_always_inline av_const int16_t av_clip_int16_c(int a) { if ((a+0x8000) & ~0xFFFF) return (int16_t)((a>>31) ^ 0x7FFF); else return (int16_t)a; } cast return values to (int32_t) for the following: static av_always_inline av_const int32_t av_clipl_int32_c(int64_t a) { if ((a+0x80000000u) & ~UINT64_C(0xFFFFFFFF)) return (a>>63) ^ 0x7FFFFFFF; else return a; } also for this one in libavutil\rational.h cast return values to (int): static inline int av_cmp_q(AVRational a, AVRational b){ const int64_t tmp= a.num * (int64_t)b.den - b.num * (int64_t)a.den; if(tmp) return (int)(((tmp ^ a.den ^ b.den)>>63)|1); else if(b.den && a.den) return 0; else if(a.num && b.num) return (int)((a.num>>31) - (b.num>>31)); else return INT_MIN; } There is no other case I have come across the produces any warnings but these. -- Ticket URL: <https://ffmpeg.org/trac/ffmpeg/ticket/512> FFmpeg <http://ffmpeg.org> FFmpeg issue tracker

1 4

#1163(FFprobe:new): ffprobe can produce invalid XML
by FFmpeg 22 Nov '13

22 Nov '13

#1163: ffprobe can produce invalid XML ----------------------------------+--------------------------------- Reporter: Ian | Owner: stefano Type: defect | Status: new Priority: normal | Component: FFprobe Version: 0.10.2 | Keywords: Blocked By: | Blocking: Reproduced by developer: 0 | Analyzed by developer: 0 ----------------------------------+--------------------------------- ffprobe can output invalid XML as xml_escape_str only handles < > ' " and &. For example most escape characters below 32 are invalid UTF-8. This replacement version of the function replaces any invalid UTF-8 characters by the inverted question mark. {{{#!C static const char *xml_escape_str(char **dst, size_t *dst_size, const char *src, void *log_ctx) { // the unknown character (inverted question mark) const unsigned char BAD_CHARACTER_1 = 194, BAD_CHARACTER_2 = 191; const char *p; char *q; int copyAll = 1; size_t size = 1; /* precompute size */ for (p = src; *p;) { int badChar = 0; unsigned char byte; ESCAPE_CHECK_SIZE(src, size, SIZE_MAX-10); byte = (unsigned char)*p; if (byte < 32 && byte != 9 && byte != 10 && byte != 13) { badChar = 1; ++p; } else if (byte < 128) { switch (byte) { case '&' : size += 5; /* & */ copyAll = 0; break; case '<' : size += 4; /* < */ copyAll = 0; break; case '>' : size += 4; /* > */ copyAll = 0; break; case '\"': size += 6; /* " */ copyAll = 0; break; case '\'': size += 6; /* ' */ copyAll = 0; break; default: size++; } ++p; ++size; } else if (byte < 0xC0) { badChar = 1; ++p; } else { int extra; copyAll = 0; if (byte < 0xe0) extra = 1; else if (byte < 0xf0) extra = 2; else if (byte < 0xf8) extra = 3; else badChar = 1; if (badChar) ++p; else { ++p; for (int i = 0; i < extra && *p; ++i, ++p) { byte = (unsigned char)*p; if ((byte & 0xc0) != 0x80) badChar = 1; } if (!badChar) size += extra; } } if (badChar) { size += 2; copyAll = 0; } } ESCAPE_REALLOC_BUF(dst_size, dst, src, size); #define COPY_STR(str) { \ const char *s = str; \ while (*s) \ *q++ = *s++; \ } p = src; q = *dst; if (copyAll) COPY_STR(p) else { while (*p) { int badChar = 0; unsigned char byte; byte = (unsigned char)*p; if (byte < 32 && byte != 9 && byte != 10 && byte != 13) { badChar = 1; ++p; } else if (byte < 128) { switch (byte) { case '&' : COPY_STR("&"); break; case '<' : COPY_STR("<"); break; case '>' : COPY_STR(">"); break; case '\"': COPY_STR("""); break; case '\'': COPY_STR("'"); break; default: *q++ = *p; } ++p; ++size; } else if (byte < 0xC0) { badChar = 1; ++p; } else { int extra; copyAll = 0; if (byte < 0xe0) extra = 1; else if (byte < 0xf0) extra = 2; else if (byte < 0xf8) extra = 3; else badChar = 1; if (badChar) ++p; else { const char *startChar = p; int i; ++p; for (i = 0; i < extra && *p; ++i, ++p) { byte = (unsigned char)*p; if ((byte & 0xc0) != 0x80) badChar = 1; } if (!badChar) { for (i = 0; i < extra;) *q++ = *startChar++; } } } if (badChar) { *q++ = BAD_CHARACTER_1; *q++ = BAD_CHARACTER_2; } } } *q = 0; return *dst; } }}} -- Ticket URL: <https://ffmpeg.org/trac/ffmpeg/ticket/1163> FFmpeg <http://ffmpeg.org> FFmpeg issue tracker

1 12