October 2024 - FFmpeg-trac - lists.ffmpeg.org

#4614(undetermined:new): sws_dither arguments aren't affecting output in colorspace conversion
by FFmpeg 21 Oct '24

21 Oct '24

#4614: sws_dither arguments aren't affecting output in colorspace conversion -------------------------------------+------------------------------------- Reporter: surfdog2020 | Type: defect Status: new | Priority: critical Component: | Version: 2.6.3 undetermined | Blocked By: Keywords: sws_dither | Reproduced by developer: 0 dithering | Blocking: | Analyzed by developer: 0 | -------------------------------------+------------------------------------- Summary of the bug: providing arguments into 'sws_dither' never affects the output. It appears that no matter which dithering algorithm you specify in sws_dither (of the 4 that are available), ffmpeg ignores it and uses the same dithering algorithm for colorspace conversion no matter what. MD5s of the output .yuv files confirms this. How to reproduce: {{{ commands only : ./ffmpeg -v debug -y -i /mnt/storage/ProRes_10bit_422.mov -t 30 -pix_fmt yuv420p -an -threads 36 -vf scale=1920:-1:sws_dither=a_dither mnt/storage/raw_8bit_420_adither.yuv ffmpeg version 2.6.3- http://johnvansickle.com/ffmpeg/ Copyright (c) 2000-2015 the FFmpeg developers ./ffmpeg -v debug -y -i /mnt/storage/ProRes_10bit_422.mov -t 30 -pix_fmt yuv420p -an -threads 36 -vf scale=1920:-1:sws_dither=bayer mnt/storage/raw_8bit_420_bayer.yuv ffmpeg version 2.6.3- http://johnvansickle.com/ffmpeg/ Copyright (c) 2000-2015 the FFmpeg developers built with gcc 4.9.2 (Debian 4.9.2-16) '''[Jared@transcoder:~/Downloads/ffmpeg-2.6.3-64bit-static]$ md5sum /mnt/storage/raw_8bit_420_bayer.yuv 203cb43ecc97aa16d7203626750a14ad /mnt/storage/raw_8bit_420_bayer.yuv''' [Jared@transcoder:~/Downloads/ffmpeg-2.6.3-64bit-static]$ md5sum /mnt/storage/raw_8bit_420_adither.yuv '''203cb43ecc97aa16d7203626750a14ad /mnt/storage/raw_8bit_420_adither.yuv''' commands with full output: [Jared@transcoder:~/Downloads/ffmpeg-2.6.3-64bit-static]$sudo ./ffmpeg -v debug -y -i /mnt/storage/ProRes_10bit_422.mov -t 30 -pix_fmt yuv420p -an -threads 36 -vf scale=1920:-1:sws_dither=a_dither mnt/storage/raw_8bit_420_adither.yuv ffmpeg version 2.6.3- http://johnvansickle.com/ffmpeg/ Copyright (c) 2000-2015 the FFmpeg developers built with gcc 4.9.2 (Debian 4.9.2-16) configuration: --enable-gpl --enable-version3 --disable-shared --disable-debug --enable-runtime-cpudetect --enable-libmp3lame --enable- libx264 --enable-libx265 --enable-libwebp --enable-libspeex --enable- libvorbis --enable-libvpx --enable-libfreetype --enable-fontconfig --enable-libxvid --enable-libopencore-amrnb --enable-libopencore-amrwb --enable-libtheora --enable-libvo-aacenc --enable-libvo-amrwbenc --enable- gray --enable-libopenjpeg --enable-libopus --enable-libass --enable-gnutls --enable-libvidstab --enable-libsoxr --cc=gcc-4.9 libavutil 54. 20.100 / 54. 20.100 libavcodec 56. 26.100 / 56. 26.100 libavformat 56. 25.101 / 56. 25.101 libavdevice 56. 4.100 / 56. 4.100 libavfilter 5. 11.102 / 5. 11.102 libswscale 3. 1.101 / 3. 1.101 libswresample 1. 1.100 / 1. 1.100 libpostproc 53. 3.100 / 53. 3.100 Splitting the commandline. Reading option '-v' ... matched as option 'v' (set logging level) with argument 'debug'. Reading option '-y' ... matched as option 'y' (overwrite output files) with argument '1'. Reading option '-i' ... matched as input file with argument '/mnt/storage/ProRes_10bit_422.mov'. Reading option '-t' ... matched as option 't' (record or transcode "duration" seconds of audio/video) with argument '30'. Reading option '-pix_fmt' ... matched as option 'pix_fmt' (set pixel format) with argument 'yuv420p'. Reading option '-an' ... matched as option 'an' (disable audio) with argument '1'. Reading option '-threads' ... matched as AVOption 'threads' with argument '36'. Reading option '-vf' ... matched as option 'vf' (set video filters) with argument 'scale=1920:-1:sws_dither=a_dither'. Reading option 'mnt/storage/raw_8bit_420.yuv_adither.yuv' ... matched as output file. Finished splitting the commandline. Parsing a group of options: global . Applying option v (set logging level) with argument debug. Applying option y (overwrite output files) with argument 1. Successfully parsed a group of options. Parsing a group of options: input file /mnt/storage/ProRes_10bit_422.mov. Successfully parsed a group of options. Opening an input file: /mnt/storage/ProRes_10bit_422.mov. [mov,mp4,m4a,3gp,3g2,mj2 @ 0x48e6680] Format mov,mp4,m4a,3gp,3g2,mj2 probed with size=2048 and score=100 [mov,mp4,m4a,3gp,3g2,mj2 @ 0x48e6680] Before avformat_find_stream_info() pos: 14083960832 bytes read:253481 seeks:5 [mov,mp4,m4a,3gp,3g2,mj2 @ 0x48e6680] All info found [mov,mp4,m4a,3gp,3g2,mj2 @ 0x48e6680] After avformat_find_stream_info() pos: 98224 bytes read:343513 seeks:6 frames:1 Input #0, mov,mp4,m4a,3gp,3g2,mj2, from '/mnt/storage/ProRes_10bit_422.mov': Metadata: creation_time : 2015-03-26 19:59:36 timecode : 00:57:50:00 Duration: 00:13:49.08, start: 0.000000, bitrate: 135899 kb/s Stream #0:0(eng), 1, 1/24000: Video: prores (apch / 0x68637061), yuv422p10le(bt709), 1920x1080, 1/24000, 135654 kb/s, SAR 1:1 DAR 16:9, 23.98 fps, 23.98 tbr, 24k tbn, 24k tbc (default) Metadata: creation_time : 2015-03-26 19:59:36 handler_name : Apple Alias Data Handler encoder : Apple ProRes 422 (HQ) Stream #0:1(eng), 0, 1/24000: Data: none (tmcd / 0x64636D74), 1/24, 0 kb/s (default) Metadata: creation_time : 2015-03-26 19:59:36 handler_name : Apple Alias Data Handler reel_name : Unnamed timecode : 00:57:50:00 Successfully opened the file. Parsing a group of options: output file mnt/storage/raw_8bit_420.yuv_adither.yuv. Applying option t (record or transcode "duration" seconds of audio/video) with argument 30. Applying option pix_fmt (set pixel format) with argument yuv420p. Applying option an (disable audio) with argument 1. Applying option vf (set video filters) with argument scale=1920:-1:sws_dither=a_dither. Successfully parsed a group of options. Opening an output file: mnt/storage/raw_8bit_420.yuv_adither.yuv. Successfully opened the file. [Parsed_scale_0 @ 0x48ee3e0] Setting 'w' to value '1920' [Parsed_scale_0 @ 0x48ee3e0] Setting 'h' to value '-1' [Parsed_scale_0 @ 0x48ee3e0] Setting 'sws_dither' to value 'a_dither' [Parsed_scale_0 @ 0x48ee3e0] Setting 'flags' to value '0x4' [Parsed_scale_0 @ 0x48ee3e0] w:1920 h:-1 flags:'0x4' interl:0 [graph 0 input from stream 0:0 @ 0x48eeae0] Setting 'video_size' to value '1920x1080' [graph 0 input from stream 0:0 @ 0x48eeae0] Setting 'pix_fmt' to value '74' [graph 0 input from stream 0:0 @ 0x48eeae0] Setting 'time_base' to value '1/24000' [graph 0 input from stream 0:0 @ 0x48eeae0] Setting 'pixel_aspect' to value '1/1' [graph 0 input from stream 0:0 @ 0x48eeae0] Setting 'sws_param' to value 'flags=2' [graph 0 input from stream 0:0 @ 0x48eeae0] Setting 'frame_rate' to value '24000/1001' [graph 0 input from stream 0:0 @ 0x48eeae0] w:1920 h:1080 pixfmt:yuv422p10le tb:1/24000 fr:24000/1001 sar:1/1 sws_param:flags=2 [format @ 0x48dbb40] compat: called with args=[yuv420p] [format @ 0x48dbb40] Setting 'pix_fmts' to value 'yuv420p' [AVFilterGraph @ 0x48dbe20] query_formats: 5 queried, 4 merged, 0 already done, 0 delayed [Parsed_scale_0 @ 0x48ee3e0] w:1920 h:1080 fmt:yuv422p10le sar:1/1 -> w:1920 h:1080 fmt:yuv420p sar:1/1 flags:0x4 detected 32 logical cores Output #0, rawvideo, to 'mnt/storage/raw_8bit_420.yuv_adither.yuv': Metadata: timecode : 00:57:50:00 encoder : Lavf56.25.101 Stream #0:0(eng), 0, 1001/24000: Video: rawvideo (I420 / 0x30323449), yuv420p, 1920x1080 [SAR 1:1 DAR 16:9], 1001/24000, q=2-31, 200 kb/s, 23.98 fps, 23.98 tbn, 23.98 tbc (default) Metadata: creation_time : 2015-03-26 19:59:36 handler_name : Apple Alias Data Handler encoder : Lavc56.26.100 rawvideo Stream mapping: Stream #0:0 -> #0:0 (prores (native) -> rawvideo (native)) Press [q] to stop, [?] for help Cliping frame in rate conversion by 0.000008 [output stream 0:0 @ 0x48d1fe0] EOF on sink link output stream 0:0:default.kbits/s No more output streams to write to, finishing. frame= 720 fps= 63 q=0.0 Lsize= 2187000kB time=00:00:30.03 bitrate=596600.2kbits/s video:2187000kB audio:0kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: 0.000000% Input file #0 (/mnt/storage/ProRes_10bit_422.mov): Input stream #0:0 (video): 721 packets read (64913072 bytes); 721 frames decoded; Input stream #0:1 (data): 0 packets read (0 bytes); Total: 721 packets (64913072 bytes) demuxed Output file #0 (mnt/storage/raw_8bit_420.yuv_adither.yuv): Output stream #0:0 (video): 720 frames encoded; 720 packets muxed (2239488000 bytes); Total: 720 packets (2239488000 bytes) muxed 721 frames successfully decoded, 0 decoding errors [AVIOContext @ 0x48ebca0] Statistics: 0 seeks, 68400 writeouts [AVIOContext @ 0x48e5e40] Statistics: 65166553 bytes read, 71 seeks [Jared@transcoder:~/Downloads/ffmpeg-2.6.3-64bit-static]$ sudo ./ffmpeg -v debug -y -i /mnt/storage/ProRes_10bit_422.mov -t 30 -pix_fmt yuv420p -an -threads 36 -vf scale=1920:-1:sws_dither=bayer mnt/storage/raw_8bit_420_bayer.yuv ffmpeg version 2.6.3- http://johnvansickle.com/ffmpeg/ Copyright (c) 2000-2015 the FFmpeg developers built with gcc 4.9.2 (Debian 4.9.2-16) configuration: --enable-gpl --enable-version3 --disable-shared --disable-debug --enable-runtime-cpudetect --enable-libmp3lame --enable- libx264 --enable-libx265 --enable-libwebp --enable-libspeex --enable- libvorbis --enable-libvpx --enable-libfreetype --enable-fontconfig --enable-libxvid --enable-libopencore-amrnb --enable-libopencore-amrwb --enable-libtheora --enable-libvo-aacenc --enable-libvo-amrwbenc --enable- gray --enable-libopenjpeg --enable-libopus --enable-libass --enable-gnutls --enable-libvidstab --enable-libsoxr --cc=gcc-4.9 libavutil 54. 20.100 / 54. 20.100 libavcodec 56. 26.100 / 56. 26.100 libavformat 56. 25.101 / 56. 25.101 libavdevice 56. 4.100 / 56. 4.100 libavfilter 5. 11.102 / 5. 11.102 libswscale 3. 1.101 / 3. 1.101 libswresample 1. 1.100 / 1. 1.100 libpostproc 53. 3.100 / 53. 3.100 Splitting the commandline. Reading option '-v' ... matched as option 'v' (set logging level) with argument 'debug'. Reading option '-y' ... matched as option 'y' (overwrite output files) with argument '1'. Reading option '-i' ... matched as input file with argument '/mnt/storage/ProRes_10bit_422.mov'. Reading option '-t' ... matched as option 't' (record or transcode "duration" seconds of audio/video) with argument '30'. Reading option '-pix_fmt' ... matched as option 'pix_fmt' (set pixel format) with argument 'yuv420p'. Reading option '-an' ... matched as option 'an' (disable audio) with argument '1'. Reading option '-threads' ... matched as AVOption 'threads' with argument '36'. Reading option '-vf' ... matched as option 'vf' (set video filters) with argument 'scale=1920:-1:sws_dither=bayer'. Reading option 'mnt/storage/raw_8bit_420.yuv_bayer.yuv' ... matched as output file. Finished splitting the commandline. Parsing a group of options: global . Applying option v (set logging level) with argument debug. Applying option y (overwrite output files) with argument 1. Successfully parsed a group of options. Parsing a group of options: input file /mnt/storage/ProRes_10bit_422.mov. Successfully parsed a group of options. Opening an input file: /mnt/storage/ProRes_10bit_422.mov. [mov,mp4,m4a,3gp,3g2,mj2 @ 0x37a5680] Format mov,mp4,m4a,3gp,3g2,mj2 probed with size=2048 and score=100 [mov,mp4,m4a,3gp,3g2,mj2 @ 0x37a5680] Before avformat_find_stream_info() pos: 14083960832 bytes read:253481 seeks:5 [mov,mp4,m4a,3gp,3g2,mj2 @ 0x37a5680] All info found [mov,mp4,m4a,3gp,3g2,mj2 @ 0x37a5680] After avformat_find_stream_info() pos: 98224 bytes read:343513 seeks:6 frames:1 Input #0, mov,mp4,m4a,3gp,3g2,mj2, from '/mnt/storage/ProRes_10bit_422.mov': Metadata: creation_time : 2015-03-26 19:59:36 timecode : 00:57:50:00 Duration: 00:13:49.08, start: 0.000000, bitrate: 135899 kb/s Stream #0:0(eng), 1, 1/24000: Video: prores (apch / 0x68637061), yuv422p10le(bt709), 1920x1080, 1/24000, 135654 kb/s, SAR 1:1 DAR 16:9, 23.98 fps, 23.98 tbr, 24k tbn, 24k tbc (default) Metadata: creation_time : 2015-03-26 19:59:36 handler_name : Apple Alias Data Handler encoder : Apple ProRes 422 (HQ) Stream #0:1(eng), 0, 1/24000: Data: none (tmcd / 0x64636D74), 1/24, 0 kb/s (default) Metadata: creation_time : 2015-03-26 19:59:36 handler_name : Apple Alias Data Handler reel_name : Unnamed timecode : 00:57:50:00 Successfully opened the file. Parsing a group of options: output file mnt/storage/raw_8bit_420.yuv_bayer.yuv. Applying option t (record or transcode "duration" seconds of audio/video) with argument 30. Applying option pix_fmt (set pixel format) with argument yuv420p. Applying option an (disable audio) with argument 1. Applying option vf (set video filters) with argument scale=1920:-1:sws_dither=bayer. Successfully parsed a group of options. Opening an output file: mnt/storage/raw_8bit_420.yuv_bayer.yuv. Successfully opened the file. [Parsed_scale_0 @ 0x37ad3e0] Setting 'w' to value '1920' [Parsed_scale_0 @ 0x37ad3e0] Setting 'h' to value '-1' [Parsed_scale_0 @ 0x37ad3e0] Setting 'sws_dither' to value 'bayer' [Parsed_scale_0 @ 0x37ad3e0] Setting 'flags' to value '0x4' [Parsed_scale_0 @ 0x37ad3e0] w:1920 h:-1 flags:'0x4' interl:0 [graph 0 input from stream 0:0 @ 0x37adae0] Setting 'video_size' to value '1920x1080' [graph 0 input from stream 0:0 @ 0x37adae0] Setting 'pix_fmt' to value '74' [graph 0 input from stream 0:0 @ 0x37adae0] Setting 'time_base' to value '1/24000' [graph 0 input from stream 0:0 @ 0x37adae0] Setting 'pixel_aspect' to value '1/1' [graph 0 input from stream 0:0 @ 0x37adae0] Setting 'sws_param' to value 'flags=2' [graph 0 input from stream 0:0 @ 0x37adae0] Setting 'frame_rate' to value '24000/1001' [graph 0 input from stream 0:0 @ 0x37adae0] w:1920 h:1080 pixfmt:yuv422p10le tb:1/24000 fr:24000/1001 sar:1/1 sws_param:flags=2 [format @ 0x379ab40] compat: called with args=[yuv420p] [format @ 0x379ab40] Setting 'pix_fmts' to value 'yuv420p' [AVFilterGraph @ 0x379ae20] query_formats: 5 queried, 4 merged, 0 already done, 0 delayed [Parsed_scale_0 @ 0x37ad3e0] w:1920 h:1080 fmt:yuv422p10le sar:1/1 -> w:1920 h:1080 fmt:yuv420p sar:1/1 flags:0x4 detected 32 logical cores Output #0, rawvideo, to 'mnt/storage/raw_8bit_420.yuv_bayer.yuv': Metadata: timecode : 00:57:50:00 encoder : Lavf56.25.101 Stream #0:0(eng), 0, 1001/24000: Video: rawvideo (I420 / 0x30323449), yuv420p, 1920x1080 [SAR 1:1 DAR 16:9], 1001/24000, q=2-31, 200 kb/s, 23.98 fps, 23.98 tbn, 23.98 tbc (default) Metadata: creation_time : 2015-03-26 19:59:36 handler_name : Apple Alias Data Handler encoder : Lavc56.26.100 rawvideo Stream mapping: Stream #0:0 -> #0:0 (prores (native) -> rawvideo (native)) Press [q] to stop, [?] for help Cliping frame in rate conversion by 0.000008 [output stream 0:0 @ 0x3790fe0] EOF on sink link output stream 0:0:default.kbits/s No more output streams to write to, finishing. frame= 720 fps= 66 q=0.0 Lsize= 2187000kB time=00:00:30.03 bitrate=596600.2kbits/s video:2187000kB audio:0kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: 0.000000% Input file #0 (/mnt/storage/ProRes_10bit_422.mov): Input stream #0:0 (video): 721 packets read (64913072 bytes); 721 frames decoded; Input stream #0:1 (data): 0 packets read (0 bytes); Total: 721 packets (64913072 bytes) demuxed Output file #0 (mnt/storage/raw_8bit_420.yuv_bayer.yuv): Output stream #0:0 (video): 720 frames encoded; 720 packets muxed (2239488000 bytes); Total: 720 packets (2239488000 bytes) muxed 721 frames successfully decoded, 0 decoding errors [AVIOContext @ 0x37aaca0] Statistics: 0 seeks, 68400 writeouts [AVIOContext @ 0x37a4e40] Statistics: 65166553 bytes read, 71 seeks [Jared@transcoder:~/Downloads/ffmpeg-2.6.3-64bit-static]$ md5sum /mnt/storage/raw_8bit_420_bayer.yuv 203cb43ecc97aa16d7203626750a14ad /mnt/storage/raw_8bit_420_bayer.yuv [Jared@transcoder:~/Downloads/ffmpeg-2.6.3-64bit-static]$ md5sum /mnt/storage/raw_8bit_420_adither.yuv 203cb43ecc97aa16d7203626750a14ad /mnt/storage/raw_8bit_420_adither.yuv }}} -- Ticket URL: <https://trac.ffmpeg.org/ticket/4614> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

1 17

#11254(swscale:new): "-sws_dither" seemingly ineffective
by FFmpeg 21 Oct '24

21 Oct '24

#11254: "-sws_dither" seemingly ineffective -------------------------------------+------------------------------------- Reporter: | Type: defect MasterQuestionable | Status: new | Priority: important Component: swscale | Version: git- | master Keywords: sws_dither | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | -------------------------------------+------------------------------------- ͏ The option appears recognized from the debug output. ͏ And indeed affecting threading: [swscaler] Error-diffusion dither is in use, scaling will be single- threaded. ͏ . ͏ But the output doesn't appear influenced: as if fixed to certain predefined dither. ͏ Testing the [ https://trac.ffmpeg.org/wiki/colorspace#yuv444p ] e.g. ͏ `ffmpeg -y -v trace -hide_banner -nostdin -nostats -i "origin(rgb24).webp" -pix_fmt yuv444p -sws_dither none -sws_flags spline+accurate_rnd+full_chroma_int -color_range 1 -colorspace 5 -color_primaries 5 -color_trc 6 -c:v libx264 -preset placebo -qp 0 -x264-params "keyint=15:no-deblock=1" "yuv444p.avi"` ͏ ; etc. ͏ Trying every possible value of "-sws_dither" in: ͏ https://ffmpeg.org/ffmpeg-scaler.html ͏ ; resulted identical output. ͏ Which is likely unsensible. ͏ The converted WebP ("yuv444p.webp") also indicated certain dither in- use: file size bigger than original ("origin(rgb24).webp"). ͏ See also: https://trac.ffmpeg.org/ticket/11182#comment:16 ͏ . ͏ Such conversion without dither tends to make colors more similar: thus improve compressibility. -- Ticket URL: <https://trac.ffmpeg.org/ticket/11254> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

1 3

#11249(avcodec:new): ffprobe reports MPEG 2 GOP-header timecodes a frame too early
by FFmpeg 20 Oct '24

20 Oct '24

#11249: ffprobe reports MPEG 2 GOP-header timecodes a frame too early -------------------------------------+------------------------------------- Reporter: | Type: defect MaxEliaserAWS | Status: new | Priority: normal Component: avcodec | Version: git- | master Keywords: | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | -------------------------------------+------------------------------------- Hi maintainers! Reaching out with an issue in the `mpeg2video` decoder and corresponding `ffprobe` output, but I also want to extend the gratitude of AWS Elemental for this awesome analysis tool! == Versions Tested I have reproduced this in the following FFMPEG/ffprobe versions: * 3.4.7 (packaged by RedHat) * 5.1.1 (static build from johnvansickle.com) * 7.0.2 (static build from johnvansickle.com) * Git commit 6cf4186d1b, compiled myself on AmazonLinux 2. This was the latest master as of this writing. == Input File Description Just to give everyone their due, I used as test content the short film _Big Buck Bunny_, which is copyright 2008 by the Blender Foundation under a CC-BY 3.0 license, see https://peach.blender.org/about/. This test file is an MPEG2 essence (e.g. ISO/IEC 13818-2 without using a transport stream wrapper.) It has a fixed 90 frame GOP size and GOP timecodes are enabled. There are no B-frames and no frame reordering. Therefore, there should be embedded timecodes on each GOP header, at frames 0, 90, 180, 270, etc, and these frame indices should be the same in decode order and presentation order. I have confirmed that this is the case using multiple other analyzer tools. You can see in these screenshots that Telestream Switch shows a timecode `00:00:03;00` on the I-frame at frame index 90 and indicates that the GOP header is present on that frame, whereas Switch does not show a GOP header present the P-frame at frame index 89 (although it can still extrapolate a timecode for that frame.) == Steps To Reproduce {{{ ffprobe -v quiet -print_format json -show_frames out_MPEG.m2v }}} == Expected Result The GOP timecodes should be reported on frames 0, 90, 180, 270, etc. The results should be consistent with the `coded_picture_number` field as well as the actual index of the frame within the JSON array. Since `coded_picture_number` appears to have been removed in latest Git, I wrote this short Python script to identify which frames have GOP timecodes in a way that will be compatible with the latest ffprobe's output format. {{{ #! /usr/bin/env python3 import sys, json if len(sys.argv) > 1: infile = open(sys.argv[1], "r") else: infile = sys.stdin content = json.load(infile) for i, frame in enumerate(content["frames"]): if "side_data_list" in frame: for side_data in frame["side_data_list"]: if side_data["side_data_type"] == "GOP timecode": print("Found GOP timecode %s on frame %d" % (side_data["timecode"], i)) break }}} == Actual Result Although the timecode is reported on frame 0 as expected, subsequently they are reported a frame too early; on frames 89, 179, 269, etc. {{{ ~/FFmpeg$ ./ffprobe -v quiet -print_format json -show_frames /tmp/out_MPEG.m2v | /tmp/analyze_ffprobe_output.py Found GOP timecode 00:00:00;00 on frame 0 Found GOP timecode 00:00:03;00 on frame 89 Found GOP timecode 00:00:06;00 on frame 179 Found GOP timecode 00:00:09;00 on frame 269 Found GOP timecode 00:00:12;00 on frame 359 Found GOP timecode 00:00:15;00 on frame 449 }}} I am confident that this does not match the actual structure of the file. ## Tentative Analysis I did some debugging of the issue in ffprobe 3.4.7; although I have reproed in latest Git, I did not repeat the debugging exercise there. This is the best diagnosis I can give but I am not an expert on this codebase so take with a grain of salt. From what I can tell, the code in mpeg12dec.c can sometimes buffer a frame internally before emitting it. I believe this is the "latency of 1 frame" documented here: https://github.com/FFmpeg/FFmpeg/blob/afb06aef7ebeaecd843d0af62dd3254624547… So when `decode_chunks` in that file encounters the GOP header, it stashes the GOP timecode in `Mpeg1Context.timecode_frame_start`: https://github.com/FFmpeg/FFmpeg/blob/afb06aef7ebeaecd843d0af62dd3254624547… https://github.com/FFmpeg/FFmpeg/blob/afb06aef7ebeaecd843d0af62dd3254624547… It then encounters the first frame in the new GOP and stores it in `MpegEncContext.cur_pic`: https://github.com/FFmpeg/FFmpeg/blob/afb06aef7ebeaecd843d0af62dd3254624547… https://github.com/FFmpeg/FFmpeg/blob/afb06aef7ebeaecd843d0af62dd3254624547… And, when `decode_chunks` is about to return, it calls into `slice_end` to flush the decoded frame: https://github.com/FFmpeg/FFmpeg/blob/afb06aef7ebeaecd843d0af62dd3254624547… However, `slice_end` can (for I-frames and P-frames) instead emit `MpegEncContext.last_pic`, which goes into the `AVFrame` which we are working on: https://github.com/FFmpeg/FFmpeg/blob/afb06aef7ebeaecd843d0af62dd3254624547… After `slice_end` and `decode_chunks` have returned, `mpeg_decode_frame` sees the timecode stashed in `Mpeg1Context.timecode_frame_start` and always attaches it to the same `AVFrame`, regardless of whether that timecode was actually destined for `cur_pic` instead of for `last_pic`: https://github.com/FFmpeg/FFmpeg/blob/afb06aef7ebeaecd843d0af62dd3254624547… Since the MPEG2 format only ever puts timecodes at the start of a new GOP (definitionally always an I frame,) then aside from frame 0, I believe this code will _always_ assign the timecode to the wrong frame. -- Ticket URL: <https://trac.ffmpeg.org/ticket/11249> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

1 19

#11253(avformat:new): Generate .lrc from .sbv or .srt have end time error on some lines
by FFmpeg 20 Oct '24

20 Oct '24

#11253: Generate .lrc from .sbv or .srt have end time error on some lines ----------------------------------+-------------------------------------- Reporter: gusong | Type: defect Status: new | Priority: normal Component: avformat | Version: git-master Keywords: lrc | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | ----------------------------------+-------------------------------------- Summary of the bug: FFmpeg generate .lrc file will show line time too long than defined. How to reproduce: {{{ input.sbv ==FILE BEGIN== 0:00:00.000,0:00:03.000 Title 0:00:10.000,0:00:15.000 Line 1 ==FILE END== % ffmpeg -i input.sbv output.lrc % cat output.lrc [re:Lavf61.7.100] [ve:61.7.100] [00:00.00]Title [00:10.00]Line 1 'Title' should show only 3 seconds, not 10 seconds, Expected output.lrc: ==FILE BEGIN== [re:Lavf61.9.100] [ve:61.9.100] [00:00.00]Title [00:03.00] [00:10.00]Line 1 ==FILE END== ffmpeg version 7.1 built on x86_64 MSYS2 }}} -- Ticket URL: <https://trac.ffmpeg.org/ticket/11253> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

1 1

#7342(avcodec:new): Wrong colours when decoding dnxhd
by FFmpeg 19 Oct '24

19 Oct '24

#7342: Wrong colours when decoding dnxhd --------------------------------------+--------------------------------- Reporter: cehoyos | Owner: Type: defect | Status: new Priority: normal | Component: avcodec Version: git-master | Keywords: dnxhd Blocked By: | Blocking: Reproduced by developer: 0 | Analyzed by developer: 0 --------------------------------------+--------------------------------- http://ffmpeg.org/pipermail/ffmpeg-user/2018-August/040775.html A user provided a dnxhd file that looks ugly when decoded with FFmpeg and an rgb file that shows the expected output, I will attach two files. {{{ $ ffmpeg -i Color_Profile_nuke11_DNxHD-mov64_444_Full.mov -qscale 2 out.avi ffmpeg version N-91548-g481741e Copyright (c) 2000-2018 the FFmpeg developers built with gcc 6.4.0 (GCC) configuration: --enable-gpl --enable-gnutls --enable-libxml2 libavutil 56. 18.102 / 56. 18.102 libavcodec 58. 22.100 / 58. 22.100 libavformat 58. 17.101 / 58. 17.101 libavdevice 58. 4.101 / 58. 4.101 libavfilter 7. 26.100 / 7. 26.100 libswscale 5. 2.100 / 5. 2.100 libswresample 3. 2.100 / 3. 2.100 libpostproc 55. 2.100 / 55. 2.100 Input #0, mov,mp4,m4a,3gp,3g2,mj2, from 'Color_Profile_nuke11_DNxHD- mov64_444_Full.mov': Metadata: major_brand : qt minor_version : 512 compatible_brands: qt uk.co.thefoundry.Application: Nuke uk.co.thefoundry.ApplicationVersion: 11.1v3 uk.co.thefoundry.YCbCrMatrix: Rec 709 uk.co.thefoundry.Colorspace: linear uk.co.thefoundry.Writer: mov64 Duration: 00:00:00.04, start: 0.000000, bitrate: 352561 kb/s Stream #0:0(eng): Video: dnxhd (DNXHD) (AVdn / 0x6E645641), yuv444p10le(pc, bt709/unknown/unknown), 1920x1080, 352321 kb/s, SAR 1:1 DAR 16:9, 24 fps, 24 tbr, 2400 tbn, 2400 tbc (default) Metadata: handler_name : VideoHandler encoder : DNxHD Please use -q:a or -q:v, -qscale is ambiguous Stream mapping: Stream #0:0 -> #0:0 (dnxhd (native) -> mpeg4 (native)) Press [q] to stop, [?] for help Output #0, avi, to 'out.avi': Metadata: major_brand : qt minor_version : 512 compatible_brands: qt uk.co.thefoundry.Application: Nuke uk.co.thefoundry.ApplicationVersion: 11.1v3 uk.co.thefoundry.YCbCrMatrix: Rec 709 uk.co.thefoundry.Colorspace: linear uk.co.thefoundry.Writer: mov64 ISFT : Lavf58.17.101 Stream #0:0(eng): Video: mpeg4 (FMP4 / 0x34504D46), yuv420p, 1920x1080 [SAR 1:1 DAR 16:9], q=2-31, 200 kb/s, 24 fps, 24 tbn, 24 tbc (default) Metadata: handler_name : VideoHandler encoder : Lavc58.22.100 mpeg4 Side data: cpb: bitrate max/min/avg: 0/0/200000 buffer size: 0 vbv_delay: -1 frame= 1 fps=0.0 q=2.0 Lsize= 87kB time=00:00:00.04 bitrate=17080.2kbits/s speed=1.22x video:81kB audio:0kB subtitle:0kB other streams:0kB global headers:0kB muxing overhead: 6.957787% }}} -- Ticket URL: <https://trac.ffmpeg.org/ticket/7342> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

1 1

#11231(undetermined:new): alphamerge complex filter delays video several seconds
by FFmpeg 19 Oct '24

19 Oct '24

#11231: alphamerge complex filter delays video several seconds -------------------------------------+------------------------------------- Reporter: degradox | Type: defect Status: new | Priority: normal Component: | Version: undetermined | unspecified Keywords: | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | -------------------------------------+------------------------------------- Summary of the bug: using complex filter with alphamerge caused audio- video desync. How to reproduce: When converting normally, the output has audio and video synced, like the input: {{{ % ffmpeg -y -i input_good.mp4 -map 0:v -map 0:a -c:v libx264 -profile:v high -level:v 4.2 -pix_fmt yuv420p \ -r 60 -b:v 600k -preset fast -c:a aac -b:a 80k -ar 48000 -ac 2 -fps_mode cfr -nostdin output_good.mp4 }}} Using filter advances somehow the video. The first minutes it's about 7 seconds. At the end the video ends about 13 seconds earlier than audio, so there's the last frame stuck for that time: {{{ % ffmpeg -y \ -i input_good.mp4 \ -filter_complex "\ [0:v]scale=1920:1080:force_original_aspect_ratio=decrease,setpts=PTS- STARTPTS [scaled_main]; \ color=c=black@0:s=1280x720:d=10000 [blank_overlay]; \ [blank_overlay]format=gray [mask_trim]; \ [blank_overlay][mask_trim]alphamerge [overlay_stream]; \ [scaled_main][overlay_stream]overlay=x=main_w-overlay_w-0:y=main_h- overlay_h-0:eof_action=pass:shortest=0 [outv]" \ -map "[outv]" -map 0:a -c:v libx264 -profile:v high -level:v 4.2 -pix_fmt yuv420p -r 60 -b:v 600k -preset fast \ -c:a aac -b:a 80k -ar 48000 -ac 2 -fps_mode cfr -nostdin output_desynced.mp4 }}} Both outputs have the same duration as the input, 51 minutes 54 seconds. -- Ticket URL: <https://trac.ffmpeg.org/ticket/11231> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

1 15

#11241(build system:new): CC_IDENT macro generation doesn't consider non-utf8 encodings causes warnings and scrambled log when compiling on Windows
by FFmpeg 15 Oct '24

15 Oct '24

#11241: CC_IDENT macro generation doesn't consider non-utf8 encodings causes warnings and scrambled log when compiling on Windows -------------------------------------+------------------------------------- Reporter: violet | Type: defect Status: new | Priority: normal Component: build | Version: git- system | master Keywords: CC_IDENT | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | -------------------------------------+------------------------------------- Summary of the bug: How to reproduce: {{{ ENV: Win10 with Simplified-Chinese encoding "gb2312", msys2, ffmpeg 7.1+ master branch, VS2022 % ./configure \src\ffmpeg\ffmpeg-7.1\config.h(1): warning C4828: 文件包含在偏移 0x66e 处开始的字符，该字符在当前源字符集中无效(代码页 65001) }}} In config.h, due to the forced "/utf8" cflag, the generated CC_IDENT looks like: {{{ #define CC_IDENT "�� x64 �� Microsoft (R) C/C++ �Ż�� 19.41.34123 ��" }}} It is actually a "gb2312" Chinese string: {{{ #define CC_IDENT "用于 x64 的 Microsoft (R) C/C++ 优化编译器 19.41.34123 版" }}} (slow fix) I think it might be better to support non-utf8 encodings CC_IDENT in macro generation code . (fast fix) Or, let `./configure` inherit CC_IDENT from environment or params, just like `./configure --extra-cflags`, add another option `./configure --cc- ident`. In this way, users can provide CC_IDENT in correct encoding manually. -- Ticket URL: <https://trac.ffmpeg.org/ticket/11241> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

1 6

#11221(avcodec:new): TSAN reported races
by FFmpeg 15 Oct '24

15 Oct '24

#11221: TSAN reported races -------------------------------------+------------------------------------- Reporter: Clément | Type: defect Bœsch | Status: new | Priority: normal Component: avcodec | Version: git- | master Keywords: race tsan | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | -------------------------------------+------------------------------------- TSAN reports a few race instances: https://fate.ffmpeg.org/report.cgi?slot=x86_64-archlinux-gcc- tsan&time=20241002095506 Most of them seem to happen in `padding_bug_score` in h263 decoder and `gray`/`non_gray` in h264 decoder. There are a few others (for example h264 `slice_table` also seems affected) but these two are the main contenders. With slice threading, HEVC seems to show up as well: https://fate.ffmpeg.org/report.cgi?time=20241002101743&slot=x86_64 -archlinux-gcc-tsan-slices This HEVC slice threading issue seems to be the cause of actual deadlocks, even without TSAN: https://fate.ffmpeg.org/report.cgi?slot=x86_64 -archlinux-gcc-threads-misc&time=20241001152120 -- Ticket URL: <https://trac.ffmpeg.org/ticket/11221> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

1 2

#11244(undetermined:new): "threads" default is overridden
by FFmpeg 14 Oct '24

14 Oct '24

#11244: "threads" default is overridden -------------------------------------+------------------------------------- Reporter: psilokos | Type: defect Status: new | Priority: normal Component: | Version: undetermined | unspecified Keywords: | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | -------------------------------------+------------------------------------- Hi, When adding an encoder to 'libavcodec/' and passing a defaults dictionary in {{{FFCodec.defaults}}} such as: {{{ const FFCodecDefault ff_xxx_defaults[] = { { "threads", "42" }, { NULL } }; const FFCodec ff_xxx_encoder = { // ... .defaults = ff_xxx_defaults } }}} The "threads" default is correctly applied in {{{init_context_defaults()}}} in 'libavcodec/options.c': {{{ 137 if (codec && codec2->defaults) { 138 int ret; 139 const FFCodecDefault *d = codec2->defaults; 140 while (d->key) { 141 ret = av_opt_set(s, d->key, d->value, 0); 142 av_assert0(ret >= 0); 143 d++; 144 } 145 } }}} {{{ * thread #1, queue = 'com.apple.main-thread', stop reason = breakpoint 1.1 * frame #0: 0x0000000101701970 ffmpeg_g`av_opt_set(obj=0x00007f8675005700, name="threads", val="42", search_flags=0) at opt.c:764:62 frame #1: 0x0000000100e83def ffmpeg_g`init_context_defaults(s=0x00007f8675005700, codec=0x00000001022821a8) at options.c:141:19 frame #2: 0x0000000100e83adf ffmpeg_g`avcodec_alloc_context3(codec=0x00000001022821a8) at options.c:156:9 frame #3: 0x000000010002428c ffmpeg_g`ost_add(mux=0x00007f8675004680, o=0x00007ff7bfefe5d8, type=AVMEDIA_TYPE_VIDEO, ist=0x00007f8675004840, ofilter=0x0000000000000000, post=0x0000000000000000) at ffmpeg_mux_init.c:1112:24 frame #4: 0x000000010002389b ffmpeg_g`map_auto_video(mux=0x00007f8675004680, o=0x00007ff7bfefe5d8) at ffmpeg_mux_init.c:1489:16 frame #5: 0x0000000100021268 ffmpeg_g`create_streams(mux=0x00007f8675004680, o=0x00007ff7bfefe5d8) at ffmpeg_mux_init.c:1805:19 frame #6: 0x00000001000208ca ffmpeg_g`of_open(o=0x00007ff7bfefe5d8, filename="y.ivf", sch=0x00007f8674705840) at ffmpeg_mux_init.c:3016:11 frame #7: 0x00000001000340fa ffmpeg_g`open_files(l=0x00007f8674705a00, inout="output", sch=0x00007f8674705840, open_file=(ffmpeg_g`of_open at ffmpeg_mux_init.c:2942)) at ffmpeg_opt.c:1213:15 frame #8: 0x0000000100033e07 ffmpeg_g`ffmpeg_parse_options(argc=12, argv=0x00007ff7bfeff2a8, sch=0x00007f8674705840) at ffmpeg_opt.c:1260:11 frame #9: 0x00000001000495a8 ffmpeg_g`main(argc=12, argv=0x00007ff7bfeff2a8) at ffmpeg.c:957:11 }}} But is then overridden by {{{avcodec_open2(avctx, codec, options)}}} in 'libavcodec/avcodec.c': {{{ 196 if ((ret = av_opt_set_dict(avctx, options)) < 0) }}} With options being fed {{{ { "threads", "auto" } }}} a few lines above the call to {{{avcodec_open2()}}} by {{{enc_open()}}} in 'fftools/ffmpeg_enc.c': {{{ 317 if (!av_dict_get(ost->encoder_opts, "threads", NULL, 0)) 318 av_dict_set(&ost->encoder_opts, "threads", "auto", 0); }}} {{{ * thread #19, name = 'vf#0:0', stop reason = breakpoint 1.1 * frame #0: 0x0000000101701970 ffmpeg_g`av_opt_set(obj=0x00007fdfbef05f80, name="threads", val="auto", search_flags=0) at opt.c:764:62 frame #1: 0x0000000101706c48 ffmpeg_g`av_opt_set_dict2(obj=0x00007fdfbef05f80, options=0x00007fdfbef05bf8, search_flags=0) at opt.c:1943:15 frame #2: 0x0000000101706d0f ffmpeg_g`av_opt_set_dict(obj=0x00007fdfbef05f80, options=0x00007fdfbef05bf8) at opt.c:1959:12 frame #3: 0x0000000100813f61 ffmpeg_g`avcodec_open2(avctx=0x00007fdfbef05f80, codec=0x00000001022821a8, options=0x00007fdfbef05bf8) at avcodec.c:198:16 frame #4: 0x0000000100010e3b ffmpeg_g`enc_open(opaque=0x00007fdfbef05b00, frame=0x00007fdfbef06a40) at ffmpeg_enc.c:335:16 frame #5: 0x000000010003d8ea ffmpeg_g`enc_open(sch=0x00007fdfbf904400, enc=0x0000600001bf9ae0, frame=0x00007fdfbef06a40) at ffmpeg_sched.c:1613:11 frame #6: 0x000000010003befd ffmpeg_g`send_to_enc(sch=0x00007fdfbf904400, enc=0x0000600001bf9ae0, frame=0x00007fdfbef06a40) at ffmpeg_sched.c:1733:19 frame #7: 0x000000010003be9e ffmpeg_g`sch_filter_send(sch=0x00007fdfbf904400, fg_idx=0, out_idx=0, frame=0x00007fdfbef06a40) at ffmpeg_sched.c:2389:12 frame #8: 0x000000010001869b ffmpeg_g`fg_output_frame(ofp=0x00007fdfbef07280, fgt=0x000070000eaddde0, frame=0x00007fdfc3b04080) at ffmpeg_filter.c:2269:15 frame #9: 0x000000010001b762 ffmpeg_g`fg_output_step(ofp=0x00007fdfbef07280, fgt=0x000070000eaddde0, frame=0x00007fdfc3b04080) at ffmpeg_filter.c:2371:11 frame #10: 0x000000010001832d ffmpeg_g`read_frames(fg=0x00007fdfbef06740, fgt=0x000070000eaddde0, frame=0x00007fdfc3b04080) at ffmpeg_filter.c:2432:23 frame #11: 0x0000000100015221 ffmpeg_g`filter_thread(arg=0x00007fdfbef06740) at ffmpeg_filter.c:2846:15 frame #12: 0x000000010003c9b1 ffmpeg_g`task_wrapper(arg=0x00006000016f8030) at ffmpeg_sched.c:2447:11 frame #13: 0x00007ff8140cc18b libsystem_pthread.dylib`_pthread_start + 99 frame #14: 0x00007ff8140c7ae3 libsystem_pthread.dylib`thread_start + 15 }}} This should be done **before** applying the defaults in {{{FFCodec.defaults}}}, or just not done if these defaults have one for "threads" already. -- Ticket URL: <https://trac.ffmpeg.org/ticket/11244> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

1 0

#11243(undetermined:new): [aac @ 0x147732550] env_facs_q 255 is invalid
by FFmpeg 14 Oct '24

14 Oct '24

#11243: [aac @ 0x147732550] env_facs_q 255 is invalid -------------------------------------+------------------------------------- Reporter: | Type: defect kairosvorgailone | Status: new | Priority: wish Component: | Version: 7.1 undetermined | Keywords: | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | -------------------------------------+------------------------------------- Summary of the bug: How to reproduce: {{{ % $ ffplay -hide_banner -nodisp -af "volume=0.05" -i 'https://0n- jazz.radionetz.de/0n-jazz.aac' [aac @ 0x147732550] env_facs_q 255 is invalid 0KB sq= 0B Input #0, aac, from 'https://0n-jazz.radionetz.de/0n-jazz.aac': Metadata: icy-index-metadata: XXX icy-logo : XXXX icy-country-code: XXX icy-country-subdivision-code: XX icy-language-codes: X icy-main-stream-url: XX icy-geo-lat-long: XXX icy-br : XXXX icy-description : XXXXX icy-genre : XXXX icy-name : XXX icy-private : XX icy-pub : X icy-url : XX StreamTitle : XXX Duration: N/A, bitrate: 64 kb/s Stream #0:0: Audio: aac (HE-AAC), 44100 Hz, stereo, fltp, 64 kb/s [aac @ 0x1477322e0] env_facs_q 255 is invalid $ ffmpeg -version ffmpeg version 7.1 Copyright (c) 2000-2024 the FFmpeg developers built with Apple clang version 16.0.0 (clang-1600.0.26.3) configuration: --prefix=/opt/homebrew/Cellar/ffmpeg/7.1 --enable-shared --enable-pthreads --enable-version3 --cc=clang --host-cflags= --host- ldflags='-Wl,-ld_classic' --enable-ffplay --enable-gnutls --enable-gpl --enable-libaom --enable-libaribb24 --enable-libbluray --enable-libdav1d --enable-libharfbuzz --enable-libjxl --enable-libmp3lame --enable-libopus --enable-librav1e --enable-librist --enable-librubberband --enable- libsnappy --enable-libsrt --enable-libssh --enable-libsvtav1 --enable- libtesseract --enable-libtheora --enable-libvidstab --enable-libvmaf --enable-libvorbis --enable-libvpx --enable-libwebp --enable-libx264 --enable-libx265 --enable-libxml2 --enable-libxvid --enable-lzma --enable- libfontconfig --enable-libfreetype --enable-frei0r --enable-libass --enable-libopencore-amrnb --enable-libopencore-amrwb --enable-libopenjpeg --enable-libspeex --enable-libsoxr --enable-libzmq --enable-libzimg --disable-libjack --disable-indev=jack --enable-videotoolbox --enable- audiotoolbox --enable-neon libavutil 59. 39.100 / 59. 39.100 libavcodec 61. 19.100 / 61. 19.100 libavformat 61. 7.100 / 61. 7.100 libavdevice 61. 3.100 / 61. 3.100 libavfilter 10. 4.100 / 10. 4.100 libswscale 8. 3.100 / 8. 3.100 libswresample 5. 3.100 / 5. 3.100 libpostproc 58. 3.100 / 58. 3.100 built on (macos, using brew install ffmpeg) }}} Patches should be submitted to the ffmpeg-devel mailing list and not this bug tracker. when running with `-report` the error was not displayed. -- Ticket URL: <https://trac.ffmpeg.org/ticket/11243> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

1 3