#7132(avfilter:new): Add threading capabilities to overlay filter
#7132: Add threading capabilities to overlay filter -------------------------------------+------------------------------------- Reporter: zerodefect | Type: Status: new | enhancement Component: avfilter | Priority: normal Keywords: | Version: git- Blocking: | master Analyzed by developer: 0 | Blocked By: | Reproduced by developer: 0 -------------------------------------+------------------------------------- I've been running some (entirely unscientific) benchmarks on the overlay filter. Compositing a frame at 1080p (YUV 422 planar) over another frame takes in the region of around 20ms on my system. Admittedly, my system isn't the latest and greatest. Having inspected the latest source code, it feels as if the overlay filter (vf_overlay.c) could benefit from threading. The trick would be to somehow keep both the current inlining while incorporating the addition of threading. Without inlining my tests indicate that performance degrades significantly. -- Ticket URL: <https://trac.ffmpeg.org/ticket/7132> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker
#7132: Add threading capabilities to overlay filter -------------------------------------+------------------------------------ Reporter: zerodefect | Owner: Type: enhancement | Status: new Priority: wish | Component: avfilter Version: git-master | Resolution: Keywords: overlay | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | -------------------------------------+------------------------------------ Changes (by cehoyos): * keywords: => overlay * priority: normal => wish -- Ticket URL: <https://trac.ffmpeg.org/ticket/7132#comment:1> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker
#7132: Add threading capabilities to overlay filter -------------------------------------+------------------------------------ Reporter: zerodefect | Owner: Type: enhancement | Status: new Priority: wish | Component: avfilter Version: git-master | Resolution: Keywords: overlay | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | -------------------------------------+------------------------------------ Comment (by richardpl): Threading will not help much, unless you have bunch of cores, SIMD will help much more. -- Ticket URL: <https://trac.ffmpeg.org/ticket/7132#comment:2> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker
#7132: Add threading capabilities to overlay filter -------------------------------------+------------------------------------ Reporter: zerodefect | Owner: Type: enhancement | Status: closed Priority: wish | Component: avfilter Version: git-master | Resolution: fixed Keywords: overlay | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | -------------------------------------+------------------------------------ Changes (by richardpl): * status: new => closed * resolution: => fixed Comment: Fixed in d54014d1573ec6e958e9c9e802e613c73c7f7ba5. Note, on average it helps only 10% with 4 cores/threads. -- Ticket URL: <https://trac.ffmpeg.org/ticket/7132#comment:3> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker
#7132: Add threading capabilities to overlay filter -------------------------------------+------------------------------------ Reporter: zerodefect | Owner: Type: enhancement | Status: closed Priority: wish | Component: avfilter Version: git-master | Resolution: fixed Keywords: overlay | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | -------------------------------------+------------------------------------ Comment (by zerodefect): Wow, quick turnaround. Thanks. Does the percentage increase have any correlation with the size of the overlay? -- Ticket URL: <https://trac.ffmpeg.org/ticket/7132#comment:4> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker
#7132: Add threading capabilities to overlay filter -------------------------------------+------------------------------------ Reporter: zerodefect | Owner: Type: enhancement | Status: closed Priority: wish | Component: avfilter Version: git-master | Resolution: fixed Keywords: overlay | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | -------------------------------------+------------------------------------ Comment (by zerodefect): By the way, should I create an additional ticket for adding SIMD paths? -- Ticket URL: <https://trac.ffmpeg.org/ticket/7132#comment:5> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker
#7132: Add threading capabilities to overlay filter -------------------------------------+------------------------------------ Reporter: zerodefect | Owner: Type: enhancement | Status: closed Priority: wish | Component: avfilter Version: git-master | Resolution: fixed Keywords: overlay | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | -------------------------------------+------------------------------------ Comment (by richardpl): SIMD added to overlay filter, for case when main has no alpha and alpha is straight. -- Ticket URL: <https://trac.ffmpeg.org/ticket/7132#comment:6> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker
participants (1)
-
FFmpeg