#2180(avformat:new): http: cookie bugs
#2180: http: cookie bugs ----------------------------------+-------------------------------------- Reporter: gjdfgh | Type: defect Status: new | Priority: normal Component: avformat | Version: git-master Keywords: | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | ----------------------------------+-------------------------------------- 1. if a cookies string is set, but no domain matches, lavf sends "Cookie: (null)". This is because it passes NULL to snprintf() somewhere. 2. ffmpeg erreneously includes the port number as part of the domain name for cookies, if the port number is included in the URL. For example, I was testing with the URL "http://localhost:10000/", and cookies for "localhost" were ignored. Using "localhost:10000" as domain name in the cookies string works, but I believe the port number should not be part of the domain name. At least wget disagrees. -- Ticket URL: <https://ffmpeg.org/trac/ffmpeg/ticket/2180> FFmpeg <http://ffmpeg.org> FFmpeg issue tracker
#2180: http: cookie bugs ------------------------------------+------------------------------------ Reporter: gjdfgh | Owner: Type: defect | Status: new Priority: normal | Component: avformat Version: git-master | Resolution: Keywords: | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | ------------------------------------+------------------------------------ Comment (by cehoyos): Please provide a failing command line including complete, uncut console output. -- Ticket URL: <https://ffmpeg.org/trac/ffmpeg/ticket/2180#comment:1> FFmpeg <http://ffmpeg.org> FFmpeg issue tracker
#2180: http: cookie bugs ------------------------------------+------------------------------------ Reporter: gjdfgh | Owner: Type: defect | Status: new Priority: normal | Component: avformat Version: git-master | Resolution: Keywords: | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | ------------------------------------+------------------------------------ Comment (by gjdfgh): But I'm not using ffmpeg by command line. -- Ticket URL: <https://ffmpeg.org/trac/ffmpeg/ticket/2180#comment:2> FFmpeg <http://ffmpeg.org> FFmpeg issue tracker
#2180: http: cookie bugs ------------------------------------+------------------------------------ Reporter: gjdfgh | Owner: Type: defect | Status: new Priority: normal | Component: avformat Version: git-master | Resolution: Keywords: | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | ------------------------------------+------------------------------------ Comment (by cehoyos): Then please explain how the problem can be reproduced and why it is not reproducible with ffmpeg (the application). -- Ticket URL: <https://ffmpeg.org/trac/ffmpeg/ticket/2180#comment:3> FFmpeg <http://ffmpeg.org> FFmpeg issue tracker
#2180: http: cookie bugs ------------------------------------+------------------------------------ Reporter: gjdfgh | Owner: Type: defect | Status: new Priority: normal | Component: avformat Version: git-master | Resolution: Keywords: | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | ------------------------------------+------------------------------------ Comment (by gjdfgh): {{{ $ ffmpeg -cookies "NAME=VALUE; path=/; domain=localhost; secure " -i http://localhost:10000/test.mkv ffmpeg version N-49529-gb45a3e1 Copyright (c) 2000-2013 the FFmpeg developers built on Feb 2 2013 13:06:37 with gcc 4.7 (Debian 4.7.2-5) configuration: --prefix=/tmp/fftemp libavutil 52. 17.100 / 52. 17.100 libavcodec 54. 91.100 / 54. 91.100 libavformat 54. 61.104 / 54. 61.104 libavdevice 54. 3.103 / 54. 3.103 libavfilter 3. 35.100 / 3. 35.100 libswscale 2. 2.100 / 2. 2.100 libswresample 0. 17.102 / 0. 17.102 }}} Receiving side: {{{ $ nc -l -p 10000 GET /test.mkv HTTP/1.1 User-Agent: Lavf54.61.104 Accept: */* Range: bytes=0- Connection: close Host: localhost:10000 Cookie: (null) }}} "(null)" is obviously not a valid cookie value. This demonstrates the two issues I pointed out. Also, I've noticed an unrelated cookie issue: with some sites, ffmpeg seems to accumulate "bad cookies". You can try with [https://github.com /mpv-player/mpv mpv] and vimeo links. On every seek (http reconnect), ffmpeg prints an additional warning reading "[http @ 0x8a43da0]Invalid cookie found, no value, path or domain specified" (e.g. the 10th seek will print 10 such messages). However, I'm far too lazy to analyze this. -- Ticket URL: <https://ffmpeg.org/trac/ffmpeg/ticket/2180#comment:4> FFmpeg <http://ffmpeg.org> FFmpeg issue tracker
#2180: http: cookie bugs -------------------------------------+------------------------------------ Reporter: gjdfgh | Owner: Type: defect | Status: new Priority: normal | Component: avformat Version: git-master | Resolution: Keywords: http cookie | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | -------------------------------------+------------------------------------ Changes (by cehoyos): * keywords: => http cookie Comment: Is this still reproducible with current FFmpeg git head? -- Ticket URL: <https://trac.ffmpeg.org/ticket/2180#comment:5> FFmpeg <http://ffmpeg.org> FFmpeg issue tracker
#2180: http: cookie bugs -------------------------------------+------------------------------------ Reporter: gjdfgh | Owner: Type: defect | Status: new Priority: normal | Component: avformat Version: git-master | Resolution: Keywords: http cookie | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | -------------------------------------+------------------------------------ Comment (by gjdfgh): I still get "Cookie: (null)" with a0e9dfb5ae5ed45090065612744e4bec10f033bf. -- Ticket URL: <https://trac.ffmpeg.org/ticket/2180#comment:6> FFmpeg <http://ffmpeg.org> FFmpeg issue tracker
participants (1)
-
FFmpeg