#3806(avformat:new): http: get_cookies() breaks for cookies with unexpected parameters and for parameters with spaces
#3806: http: get_cookies() breaks for cookies with unexpected parameters and for parameters with spaces -------------------------------------+------------------------------------- Reporter: cakemonster | Type: defect Status: new | Priority: normal Component: avformat | Version: git- Keywords: http cookie | master Blocking: | Blocked By: Analyzed by developer: 0 | Reproduced by developer: 0 -------------------------------------+------------------------------------- If a site sets a cookie that includes (for example) the !HttpOnly parameter get_cookies() fails to return that cookie for use with subsequent requests. Instead "Cookie: !HttpOnly" is sent to the server. Also if a site sets the Expires parameter (which includes spaces by definition) the parsing breaks due to the "; " delimiter list to av_strtok and "Cookie: GMT" will be sent instead of the real cookie. Ugly hack that fixes these 2 cases but will break for any other unknown cookie parameters attached. -- Ticket URL: <https://trac.ffmpeg.org/ticket/3806> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker
#3806: http: get_cookies() breaks for cookies with unexpected parameters and for parameters with spaces -------------------------------------+------------------------------------ Reporter: cakemonster | Owner: Type: defect | Status: new Priority: normal | Component: avformat Version: git-master | Resolution: Keywords: http cookie | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | -------------------------------------+------------------------------------ Comment (by cehoyos): Please send two patches that do not include any white space changes to the ffmpeg-devel mailing list where patches are discussed and can be reviewed. Patches on this bug tracker are usually ignored. -- Ticket URL: <https://trac.ffmpeg.org/ticket/3806#comment:1> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker
#3806: http: get_cookies() breaks for cookies with unexpected parameters and for parameters with spaces -------------------------------------+------------------------------------ Reporter: cakemonster | Owner: Type: defect | Status: closed Priority: normal | Component: avformat Version: git-master | Resolution: fixed Keywords: http cookie | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | -------------------------------------+------------------------------------ Changes (by cehoyos): * status: new => closed * resolution: => fixed Comment: I believe this was fixed by Nicolas George in 481cbc5a and 4bebce06 Please reopen this ticket if the issue is still reproducible with current FFmpeg git head or 2.4. -- Ticket URL: <https://trac.ffmpeg.org/ticket/3806#comment:2> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker
participants (1)
-
FFmpeg