#7799(avcodec:new): hevc_mp4toannexb filter inserts extradata wrong position

older
#11337(undetermined:new): asegment...

FFmpeg

18 Mar 2019 18 Mar '19

7:05 a.m.

#7799: hevc_mp4toannexb filter inserts extradata wrong position ---------------------------------+--------------------------------------- Reporter: gudbooy | Type: defect Status: new | Priority: normal Component: avcodec | Version: unspecified Keywords: | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | ---------------------------------+--------------------------------------- Summary of the bug: After applied hevc_mp4toannexb filter to the attached video (refer to the below link), the frames become broken from the video players (e.g. VLC, ffplay) The problem is caused by prepending the extra-data to IRAP frames in libavcodec/hevc_mp4toannexb_bsf.c. This video contains own vps/sps/pps for every IRAP frames. The extradata from hevcc is slightly different from every IRAP frames have (in this case QP value is different) and the hevc_mp4toannexb filter prepends the different extradata to every IRAP frames, causing the broken frames. Video File Repo : https://www.dropbox.com/s/tpyohk6vf096zxm/hevc_after_mp4toannexb_conversion_... I am afraid that I can't connect to ftp://upload.ffmpeg.org, so I just attached to the dropbox url How to reproduce: {{{ % ffmpeg -i hevc_after_mp4toannexb_conversion_qp_value_modified.mp4 -codec copy -bsf:v hevc_mp4toannexb output.hevc $vlc output.hevc }}} Patches should be submitted to the ffmpeg-devel mailing list and not this bug tracker. -- Ticket URL: <https://trac.ffmpeg.org/ticket/7799> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

Show replies by date

FFmpeg

18 Mar 18 Mar

12:38 p.m.

#7799: hevc_mp4toannexb filter inserts extradata wrong position -------------------------------------+----------------------------------- Reporter: gudbooy | Owner: Type: defect | Status: new Priority: normal | Component: avcodec Version: unspecified | Resolution: Keywords: | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | -------------------------------------+----------------------------------- Changes (by cehoyos): * Attachment "hevc_after_mp4toannexb_conversion_qp_value_modified.mp4" added. -- Ticket URL: <https://trac.ffmpeg.org/ticket/7799> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

FFmpeg

12:38 p.m.

#7799: hevc_mp4toannexb filter inserts extradata wrong position -------------------------------------+----------------------------------- Reporter: gudbooy | Owner: Type: defect | Status: new Priority: normal | Component: avcodec Version: unspecified | Resolution: Keywords: | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | -------------------------------------+----------------------------------- Comment (by cehoyos): How did you create the input file? -- Ticket URL: <https://trac.ffmpeg.org/ticket/7799#comment:1> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

FFmpeg

19 Mar 19 Mar

2:07 a.m.

...

How did you create the input file?

Unfortunately, I did not create the video. It is automatically transcoded via a messenger application. (I do not exactly know how they transcode) I know how to avoid this issue, (just not prepend the extra-data, if the extra-data has already existed on IRAP frames) However, I do not exactly know whether this solution is correct or not. -- Ticket URL: <https://trac.ffmpeg.org/ticket/7799#comment:2> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

FFmpeg

2:07 a.m.

...

How did you create the input file?

Unfortunately, I did not create the video. It is automatically transcoded via a messenger application. (I do not exactly know how they transcode) I know how to avoid this issue, (just not prepend the extra-data, if the extra-data has already existed on IRAP frames) However, I do not exactly know whether this solution is correct or not. -- Ticket URL: <https://trac.ffmpeg.org/ticket/7799#comment:3> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

FFmpeg

9:01 a.m.

...

Replying to [comment:1 cehoyos]:

...
How did you create the input file?

Unfortunately, I did not create the video. It is automatically

#7799: hevc_mp4toannexb filter inserts extradata wrong position -------------------------------------+----------------------------------- Reporter: gudbooy | Owner: Type: defect | Status: new Priority: normal | Component: avcodec Version: unspecified | Resolution: Keywords: | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | -------------------------------------+----------------------------------- Comment (by cehoyos): Replying to [comment:3 gudbooy]: transcoded via a messenger application. (I do not exactly know how they transcode) Which one? The file indicates that it was created with FFmpeg. -- Ticket URL: <https://trac.ffmpeg.org/ticket/7799#comment:3> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

FFmpeg

11:02 a.m.

#7799: hevc_mp4toannexb filter inserts extradata wrong position -------------------------------------+----------------------------------- Reporter: gudbooy | Owner: Type: defect | Status: new Priority: normal | Component: avcodec Version: unspecified | Resolution: Keywords: | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | -------------------------------------+----------------------------------- Comment (by gudbooy): The file I uploaded (hevc_after_mp4toannexb_conversion_qp_value_modified.mp4). -- Ticket URL: <https://trac.ffmpeg.org/ticket/7799#comment:4> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

FFmpeg

4:37 p.m.

#7799: hevc_mp4toannexb filter inserts extradata wrong position -------------------------------------+----------------------------------- Reporter: gudbooy | Owner: Type: defect | Status: new Priority: normal | Component: avcodec Version: unspecified | Resolution: Keywords: | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | -------------------------------------+----------------------------------- Comment (by cehoyos): Which messenger application? -- Ticket URL: <https://trac.ffmpeg.org/ticket/7799#comment:5> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

FFmpeg

21 Mar 21 Mar

9:41 a.m.

#7799: hevc_mp4toannexb filter inserts extradata wrong position -------------------------------------+----------------------------------- Reporter: gudbooy | Owner: Type: defect | Status: new Priority: normal | Component: avcodec Version: unspecified | Resolution: Keywords: | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | -------------------------------------+----------------------------------- Comment (by gudbooy): The messenger application called KAKAO-TALK, which is the famous app in Korea The original one is H.264 encoded Video transcoded by Xiomi video editing application. -- Ticket URL: <https://trac.ffmpeg.org/ticket/7799#comment:6> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

FFmpeg

9:47 a.m.

#7799: hevc_mp4toannexb filter inserts extradata wrong position ------------------------------------+----------------------------------- Reporter: gudbooy | Owner: Type: defect | Status: new Priority: normal | Component: avcodec Version: git-master | Resolution: Keywords: hevc | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | ------------------------------------+----------------------------------- Changes (by cehoyos): * keywords: => hevc * version: unspecified => git-master -- Ticket URL: <https://trac.ffmpeg.org/ticket/7799#comment:7> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

FFmpeg

28 Nov 28 Nov

2:04 p.m.

#7799: hevc_mp4toannexb filter inserts extradata wrong position ------------------------------------+----------------------------------- Reporter: gudbooy | Owner: Type: defect | Status: new Priority: normal | Component: avcodec Version: git-master | Resolution: Keywords: hevc | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | ------------------------------------+----------------------------------- Comment (by taliho): hevc_mp4toannexb bsf doesn't insert correct parameter sets if they change in-band. For now, you can just use hevc_metadata filter to do the same job: ./ffmpeg -i hevc_after_mp4toannexb_conversion_qp_value_modified.mp4 -bsf:v hevc_metadata -codec:v copy output.hevc -- Ticket URL: <https://trac.ffmpeg.org/ticket/7799#comment:8> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

FFmpeg

10 Dec 10 Dec

2:12 a.m.

...

hevc_mp4toannexb bsf doesn't insert correct parameter sets if they change in-band. For now, you can just use hevc_metadata filter to do the same job:

./ffmpeg -i hevc_after_mp4toannexb_conversion_qp_value_modified.mp4 -bsf:v hevc_metadata -codec:v copy output.hevc

Thanks, I will try it and let you know -- Ticket URL: <https://trac.ffmpeg.org/ticket/7799#comment:9> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

FFmpeg

28 Jul 28 Jul

2:45 p.m.

New subject: #7799(avcodec:open): hevc_mp4toannexb filter inserts extradata wrong position

#7799: hevc_mp4toannexb filter inserts extradata wrong position ------------------------------------+----------------------------------- Reporter: gudbooy | Owner: Type: defect | Status: open Priority: normal | Component: avcodec Version: git-master | Resolution: Keywords: hevc | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | ------------------------------------+----------------------------------- Changes (by Balling): * status: new => open Comment: https://patchwork.ffmpeg.org/project/ffmpeg/patch/20191016025040.31273-2-and... Apply that already. Issue showed itself here: https://github.com/rigaya/NVEnc/issues/237 -- Ticket URL: <https://trac.ffmpeg.org/ticket/7799#comment:10> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

FFmpeg

23 Sep 23 Sep

4:54 p.m.

New subject: #7799(avcodec:open): hevc_mp4toannexb filter inserts extradata wrong position

#7799: hevc_mp4toannexb filter inserts extradata wrong position ------------------------------------+----------------------------------- Reporter: gudbooy | Owner: Type: defect | Status: open Priority: normal | Component: avcodec Version: git-master | Resolution: Keywords: hevc | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | ------------------------------------+----------------------------------- Comment (by Balling): Guys, when this will be fixed? We have a patch. -- Ticket URL: <https://trac.ffmpeg.org/ticket/7799#comment:11> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

FFmpeg

10 Sep 10 Sep

1:41 p.m.

New subject: #7799(avcodec:open): hevc_mp4toannexb filter inserts extradata wrong position

#7799: hevc_mp4toannexb filter inserts extradata wrong position ------------------------------------+----------------------------------- Reporter: Hyemin Lee | Owner: (none) Type: defect | Status: open Priority: normal | Component: avcodec Version: git-master | Resolution: Keywords: hevc | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | ------------------------------------+----------------------------------- Comment (by Balling): Looks related https://patchwork.ffmpeg.org/project/ffmpeg/patch/20210910040948.14186-1-hai... -- Ticket URL: <https://trac.ffmpeg.org/ticket/7799#comment:12> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

FFmpeg

11 Sep 11 Sep

12:55 p.m.

New subject: #7799(avcodec:open): hevc_mp4toannexb filter inserts extradata wrong position

#7799: hevc_mp4toannexb filter inserts extradata wrong position ------------------------------------+----------------------------------- Reporter: Hyemin Lee | Owner: (none) Type: defect | Status: open Priority: normal | Component: avcodec Version: git-master | Resolution: Keywords: hevc | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | ------------------------------------+----------------------------------- Comment (by Balling): Sorry, it does NOT just look related, it is the "same" patch since FATE had the same change!! PLEASE APPLY!!! {{{ -fate-hevc-bsf-mp4toannexb: REF = 1873662a3af1848c37e4eb25722c8df9 +fate-hevc-bsf-mp4toannexb: REF = 3c9d998a3aa2b9e0fb1c1f434952bf8b }}} -- Ticket URL: <https://trac.ffmpeg.org/ticket/7799#comment:13> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

FFmpeg

10 Nov 10 Nov

4:04 a.m.

New subject: #7799(avcodec:open): hevc_mp4toannexb filter inserts extradata wrong position

#7799: hevc_mp4toannexb filter inserts extradata wrong position ------------------------------------+----------------------------------- Reporter: Hyemin Lee | Owner: (none) Type: defect | Status: open Priority: normal | Component: avcodec Version: git-master | Resolution: Keywords: hevc | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | ------------------------------------+----------------------------------- Comment (by Balling): Hey, please apply the LGTM'd patch! -- Ticket URL: <https://trac.ffmpeg.org/ticket/7799#comment:14> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

FFmpeg

20 Dec 20 Dec

12:25 p.m.

New subject: #7799(avcodec:open): hevc_mp4toannexb filter inserts extradata wrong position

#7799: hevc_mp4toannexb filter inserts extradata wrong position ------------------------------------+----------------------------------- Reporter: Hyemin Lee | Owner: (none) Type: defect | Status: open Priority: normal | Component: avcodec Version: git-master | Resolution: Keywords: hevc | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | ------------------------------------+----------------------------------- Comment (by Balling): Ping again! -- Ticket URL: <https://trac.ffmpeg.org/ticket/7799#comment:15> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

FFmpeg

17 Mar 17 Mar

11:22 a.m.

New subject: #7799(avcodec:open): hevc_mp4toannexb filter inserts extradata wrong position

#7799: hevc_mp4toannexb filter inserts extradata wrong position ------------------------------------+----------------------------------- Reporter: Hyemin Lee | Owner: (none) Type: defect | Status: open Priority: normal | Component: avcodec Version: git-master | Resolution: Keywords: hevc | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | ------------------------------------+----------------------------------- Comment (by Balling): New patch: https://patchwork.ffmpeg.org/project/ffmpeg/patch/20220317063546.7429-1-haih... -- Ticket URL: <https://trac.ffmpeg.org/ticket/7799#comment:16> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

FFmpeg

18 Mar 18 Mar

1:42 a.m.

New subject: #7799(avcodec:open): hevc_mp4toannexb filter inserts extradata wrong position

...

New patch: https://patchwork.ffmpeg.org/project/ffmpeg/patch/20220317063546.7429-1-haih...

Does this patch work for you ? Could you please comment on FFmpeg mailing list if it works ? thx -- Ticket URL: <https://trac.ffmpeg.org/ticket/7799#comment:17> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

FFmpeg

4:30 p.m.

New subject: #7799(avcodec:open): hevc_mp4toannexb filter inserts extradata wrong position

...

Replying to [comment:16 Balling]:

...
New patch: https://patchwork.ffmpeg.org/project/ffmpeg/patch/20220317063546.7429-1-haih...

Does this patch work for you ? Could you please comment on FFmpeg mailing list if it works ? thx

...

One difference is that hevc_metadata currently only keeps the base layers (nuh_layer_id == 0), whereas hevc_mp4toannexb copies everything (before my

Please note that there is workaround with hevc_metadata, that is not affected, but in 2019 at least it could not "-c copy" nuh_layer_id != 0 patch). hevc_metadata will have a slightly higher complexity as it parses the full parameter sets. I will just point out how to test this bug on latest master: Bad: {{{ ffmpeg.exe -i hevc_after_mp4toannexb_conversion_qp_value_modified.mp4 -c copy ajcwsaq.h265 ffplay.exe ajcwsaq.h265 }}} Good: {{{ ffmpeg.exe -i hevc_after_mp4toannexb_conversion_qp_value_modified.mp4 -bsf:v hevc_metadata -c copy ajcwsaq1.h265 ffplay ajcwsaq1.h265 }}} -- Ticket URL: <https://trac.ffmpeg.org/ticket/7799#comment:18> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

FFmpeg

8:54 p.m.

New subject: #7799(avcodec:open): hevc_mp4toannexb filter inserts extradata wrong position (hevc_cuvid ffplay too) (was: hevc_mp4toannexb filter inserts extradata wrong position)

#7799: hevc_mp4toannexb filter inserts extradata wrong position (hevc_cuvid ffplay too) ------------------------------------+----------------------------------- Reporter: Hyemin Lee | Owner: (none) Type: defect | Status: open Priority: normal | Component: avcodec Version: git-master | Resolution: Keywords: hevc | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | ------------------------------------+----------------------------------- Changes (by Balling): * summary: hevc_mp4toannexb filter inserts extradata wrong position => hevc_mp4toannexb filter inserts extradata wrong position (hevc_cuvid ffplay too) Comment: I can varify that you patch, Haihao, fixed the bug! I will attach the original file and fixed one. I am not sure whether it is a good idea to put data right behind "x265 (build 110) - 2.3:[Linux][GCC 5.4.0]" decoder info... But what do I know. hevc_metadata does not appear to be able to handle the file perfectly, it looks like it truncates some 00 00 00 01 from {{{ 00 00 00 01 40 01 0C 01 FF FF 01 60 00 00 03 00 90 00 00 03 00 00 03 00 5D 95 94 09 00 00 00 01 42 01 01 01 60 00 00 03 00 90 00 00 03 00 00 03 00 5D A0 02 80 80 2D 16 59 59 52 93 0B C0 40 40 00 00 03 00 40 00 00 07 82 00 00 00 01 44 01 C0 73 C1 89}}} -- Ticket URL: <https://trac.ffmpeg.org/ticket/7799#comment:19> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

FFmpeg

8:56 p.m.

New subject: #7799(avcodec:open): hevc_mp4toannexb filter inserts extradata wrong position (hevc_cuvid ffplay too)

FFmpeg

8:57 p.m.

New subject: #7799(avcodec:open): hevc_mp4toannexb filter inserts extradata wrong position (hevc_cuvid ffplay too)

FFmpeg

19 Mar 19 Mar

8:26 p.m.

New subject: #7799(avcodec:open): hevc_mp4toannexb filter inserts extradata wrong position (hevc_cuvid ffplay too)

FFmpeg

27 Jul 27 Jul

2:16 a.m.

New subject: #7799(avcodec:open): hevc_mp4toannexb filter inserts extradata wrong position (hevc_cuvid ffplay too)

FFmpeg

2:40 a.m.

New subject: #7799(avcodec:open): hevc_mp4toannexb filter inserts extradata wrong position (hevc_cuvid ffplay too)

...

This only mitigates a certain case of wrongly inserted extradata; it does not fix the underlying issue

Also

...

complexity emanating from HEVC's layers.

is hevc_metadata problem. '''And to Soft Works:'''

...

I had missed this conversation and just recently noticed that Haihao's Patch fixes HEVC decoding issues with certain files that I'm seeing for a long time already

Where are the samples? -- Ticket URL: <https://trac.ffmpeg.org/ticket/7799#comment:23> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

FFmpeg

28 Sep 28 Sep

4:08 p.m.

New subject: #7799(avcodec:open): hevc_mp4toannexb filter inserts extradata wrong position (hevc_cuvid ffplay too)

FFmpeg

6:39 p.m.

New subject: #7799(avcodec:open): hevc_mp4toannexb filter inserts extradata wrong position (hevc_cuvid ffplay too)

FFmpeg

9 Oct 9 Oct

4:10 a.m.

New subject: #7799(avcodec:open): hevc_mp4toannexb filter inserts extradata wrong position (hevc_cuvid ffplay too)

#7799: hevc_mp4toannexb filter inserts extradata wrong position (hevc_cuvid ffplay too) -------------------------------------+------------------------------------- Reporter: Hyemin Lee | Owner: Carl | Eugen Hoyos Type: defect | Status: open Priority: normal | Component: avcodec Version: git-master | Resolution: Keywords: hevc | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | -------------------------------------+------------------------------------- Changes (by Balling): * owner: softworkz => Carl Eugen Hoyos Comment: Carl? -- Ticket URL: <https://trac.ffmpeg.org/ticket/7799#comment:26> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

FFmpeg

7 Dec 7 Dec

10:27 p.m.

New subject: #7799(avcodec:open): hevc_mp4toannexb filter inserts extradata wrong position (hevc_cuvid ffplay too)

#7799: hevc_mp4toannexb filter inserts extradata wrong position (hevc_cuvid ffplay too) -------------------------------------+------------------------------------- Reporter: Hyemin Lee | Owner: Carl | Eugen Hoyos Type: defect | Status: open Priority: normal | Component: avcodec Version: git-master | Resolution: Keywords: hevc | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | -------------------------------------+------------------------------------- Comment (by Balling): https://github.com/FFmpeg/FFmpeg/commit/0f824d792d20783fda64279ab94e16676e48... Chabged the md5 in FATE, but https://patchwork.ffmpeg.org/project/ffmpeg/patch/20210910040948.14186-1-hai... is still to be applied. So we need a new patch, btw this does not fix this issue, it is the other patch. -- Ticket URL: <https://trac.ffmpeg.org/ticket/7799#comment:27> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker

494

Age (days ago)

2585

Last active (days ago)

List overview

Download

30 comments

1 participants

participants (1)

FFmpeg

#7799(avcodec:new): hevc_mp4toannexb filter inserts extradata wrong position

tags

participants (1)