#1351: Removal of mpeg2 low-res video decoding: why? -------------------------------------+------------------------------------- Reporter: jyavenard | Owner: Type: defect | Status: new Priority: normal | Component: Version: unspecified | undetermined Keywords: | Resolution: Blocking: | Blocked By: Analyzed by developer: 0 | Reproduced by developer: 0 -------------------------------------+------------------------------------- Comment (by jyavenard): Not this the merge in 92ef4be4ab9fbb7d901b22e0036a4ca90b00a476 Do you really think I would have lodged this issue if that wasn't the case? {{{ commit 92ef4be4ab9fbb7d901b22e0036a4ca90b00a476 Merge: 2e07f42 d526c53 Author: Michael Niedermayer <michaelni@gmx.at> Date: Sun Apr 22 22:26:42 2012 +0200 Merge remote-tracking branch 'qatar/master' * qatar/master: ARM: allow runtime masking of CPU features dsputil: remove unused functions mov: Treat keyframe indexes as 1-origin if starting at non-zero. mov: Take stps entries into consideration also about key_off. Remove lowres video decoding }}} which included the commit in the original report -- Ticket URL: <https://ffmpeg.org/trac/ffmpeg/ticket/1351#comment:2> FFmpeg <http://ffmpeg.org> FFmpeg issue tracker

#1351: mpeg2video lowres support -------------------------------------+------------------------------------- Reporter: jyavenard | Owner: Type: defect | Status: closed Priority: important | Component: avcodec Version: git-master | Resolution: fixed Keywords: mpeg2video | Blocked By: regression | Reproduced by developer: 1 Blocking: | Analyzed by developer: 0 | -------------------------------------+------------------------------------- Changes (by cehoyos): * status: open => closed * resolution: => fixed Comment: This appears to have been fixed, thank you for your report! -- Ticket URL: <https://ffmpeg.org/trac/ffmpeg/ticket/1351#comment:4> FFmpeg <http://ffmpeg.org> FFmpeg issue tracker

#1351: mpeg2video lowres support -------------------------------------+------------------------------------- Reporter: jyavenard | Owner: Type: defect | Status: reopened Priority: important | Component: avcodec Version: git-master | Resolution: Keywords: mpeg2video | Blocked By: regression lowres | Reproduced by developer: 1 Blocking: | Analyzed by developer: 0 | -------------------------------------+------------------------------------- Changes (by jyavenard): * status: closed => reopened * resolution: fixed => Comment: Thank you for this... However, are you sure the revert is complete? The git comment itself is wrong, and the sha mentioned isn't the correct one: http://git.videolan.org/?p=ffmpeg.git;a=commit;h=5e50a5724bb00c44a98bd89f57c... The merged commit (from Libav) that removed lowres was 2bcbd98459915baefc15043d02f4a942ebcd33da http://git.videolan.org/?p=ffmpeg.git;a=commit;h=2bcbd98459915baefc15043d02f... it modified the files: {{{ avconv.c avplay.c libavcodec/alpha/dsputil_alpha.c libavcodec/arm/dsputil_init_arm.c libavcodec/arm/dsputil_init_armv5te.c libavcodec/arm/dsputil_init_armv6.c libavcodec/arm/dsputil_init_neon.c libavcodec/avcodec.h libavcodec/dsputil.c libavcodec/dsputil.h libavcodec/dv.c libavcodec/dvdec.c libavcodec/error_resilience.c libavcodec/flvdec.c libavcodec/h261dec.c libavcodec/h263dec.c libavcodec/intrax8.c libavcodec/jrevdct.c libavcodec/libopenjpeg.c libavcodec/mjpegbdec.c libavcodec/mjpegdec.c libavcodec/mpeg12.c libavcodec/mpeg4videodec.c libavcodec/mpegvideo.c libavcodec/mpegvideo.h libavcodec/msmpeg4.c libavcodec/mxpegdec.c libavcodec/options_table.h libavcodec/ppc/dsputil_ppc.c libavcodec/rv10.c libavcodec/sp5xdec.c libavcodec/utils.c libavcodec/wmv2dec.c libavcodec/x86/dsputil_mmx.c }}} Also, a following commits removed DSP code that were used for lowres support: d7458bc8c62ae1cb2ffc805b989fcddf4029dda6 http://git.videolan.org/?p=ffmpeg.git;a=commit;h=d7458bc8c62ae1cb2ffc805b989... So the reversal made is only partial and only going to have an effect on mpeg decoder... BTW, I agree, there's no way four extra bit shifts would have caused a drop of speed of 3%... Those stats could have only been made up... -- Ticket URL: <https://ffmpeg.org/trac/ffmpeg/ticket/1351#comment:6> FFmpeg <http://ffmpeg.org> FFmpeg issue tracker

#1351: mpeg2video lowres support -------------------------------------+------------------------------------- Reporter: jyavenard | Owner: Type: defect | Status: reopened Priority: important | Component: avcodec Version: git-master | Resolution: Keywords: mpeg2video | Blocked By: regression lowres | Reproduced by developer: 1 Blocking: | Analyzed by developer: 0 | -------------------------------------+------------------------------------- Comment (by jyavenard): Command line of what? this is a libavcodec issue and about features dropped from it. yes, mpeg2video lowres support was re-enabled. But what about lowres support for all the other codecs that were removed in that same commit. Those were not reverted, i have listed above all the codecs that suddenly saw their lowres support dropped. -- Ticket URL: <https://ffmpeg.org/trac/ffmpeg/ticket/1351#comment:8> FFmpeg <http://ffmpeg.org> FFmpeg issue tracker

#1351: mpeg2video lowres support -------------------------------------+------------------------------------- Reporter: jyavenard | Owner: Type: defect | Status: reopened Priority: important | Component: avcodec Version: git-master | Resolution: Keywords: mpeg2video | Blocked By: regression lowres | Reproduced by developer: 1 Blocking: | Analyzed by developer: 0 | -------------------------------------+------------------------------------- Comment (by michael): Note, the lowres removial was reverted in 2 commits, first was 70d54392f5015b9c6594fcae558f59f952501e3b. Ive not double checked now but i belive that the 2 commits brought all parts back. -- Ticket URL: <https://ffmpeg.org/trac/ffmpeg/ticket/1351#comment:10> FFmpeg <http://ffmpeg.org> FFmpeg issue tracker

#1351: mpeg2video lowres support -------------------------------------+------------------------------------- Reporter: jyavenard | Owner: Type: defect | Status: reopened Priority: important | Component: avcodec Version: git-master | Resolution: Keywords: mpeg2video | Blocked By: regression lowres | Reproduced by developer: 1 Blocking: | Analyzed by developer: 0 | -------------------------------------+------------------------------------- Comment (by jyavenard): Thanks Michael.. I see what went on... I was confused with the name of "lowres2" and skipped that commit So it was just mpeg2 that didn't get revert properly at first... Excellent news.. I can tell you for sure now that MythTV will sync with ffmpeg from now on. -- Ticket URL: <https://ffmpeg.org/trac/ffmpeg/ticket/1351#comment:12> FFmpeg <http://ffmpeg.org> FFmpeg issue tracker