#7217(ffprobe:new): ffprobe produces wrong XML; "data_hash" attribute sometimes in text
#7217: ffprobe produces wrong XML; "data_hash" attribute sometimes in text ------------------------------------+---------------------------------- Reporter: carlreinke | Type: defect Status: new | Priority: normal Component: ffprobe | Version: 3.2.4 Keywords: | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | ------------------------------------+---------------------------------- The "data_hash" attribute is sometimes in the text instead of in the tag. How to reproduce: {{{ $ ffprobe -v 0 -print_format xml=xsd_strict=1 -show_packets -show_data_hash sha160 -noshow_private_data -read_intervals %+#1 kahvi048_pinza-thickline.ogg <?xml version="1.0" encoding="UTF-8"?> <ffprobe:ffprobe xmlns:xsi='http://www.w3.org/2001/XMLSchema-instance' xmlns:ffprobe='http://www.ffmpeg.org/schema/ffprobe' xsi:schemaLocation='http://www.ffmpeg.org/schema/ffprobe ffprobe.xsd'> <packets> <packet codec_type="audio" stream_index="0" pts="-128" pts_time="-0.002902" dts="-128" dts_time="-0.002902" duration="128" duration_time="0.002902" size="60" pos="4315" flags="K_"> <side_data_list> <side_data side_data_type="Metadata Update"/> </side_data_list> data_hash="SHA160:5e0e1c526cd631e016e378bc99302e63ea40e381" </packet> </packets> </ffprobe:ffprobe> }}} File used is available [https://files.scene.org/get/music/groups/kahvicollective/kahvi048_pinza- thickline.ogg here]. -- Ticket URL: <https://trac.ffmpeg.org/ticket/7217> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker
#7217: ffprobe produces wrong XML; "data_hash" attribute sometimes in text ------------------------------------+----------------------------------- Reporter: carlreinke | Owner: Type: defect | Status: new Priority: normal | Component: ffprobe Version: git-master | Resolution: Keywords: | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | ------------------------------------+----------------------------------- Changes (by cehoyos): * version: 3.2.4 => git-master -- Ticket URL: <https://trac.ffmpeg.org/ticket/7217#comment:1> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker
#7217: ffprobe produces wrong XML; "data_hash" attribute sometimes in text ------------------------------------+----------------------------------- Reporter: carlreinke | Owner: Type: defect | Status: open Priority: normal | Component: ffprobe Version: git-master | Resolution: Keywords: | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | ------------------------------------+----------------------------------- Changes (by Balling): * status: new => open Comment: Yep... So where should it be? Like in <side_data data_hash="SHA160:5e0e1c526cd631e016e378bc99302e63ea40e381"> or where? -- Ticket URL: <https://trac.ffmpeg.org/ticket/7217#comment:2> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker
#7217: ffprobe produces wrong XML; "data_hash" attribute sometimes in text ------------------------------------+----------------------------------- Reporter: carlreinke | Owner: Type: defect | Status: open Priority: normal | Component: ffprobe Version: git-master | Resolution: Keywords: | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | ------------------------------------+----------------------------------- Comment (by carlreinke): According to [https://github.com/FFmpeg/FFmpeg/blob/f39678b3a99eb8f1503aed9fa26f3ef117d174... the schema], it should be on an attribute on the "packet" tag. -- Ticket URL: <https://trac.ffmpeg.org/ticket/7217#comment:3> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker
#7217: ffprobe produces wrong XML; "data_hash" attribute sometimes in text -------------------------------------+----------------------------------- Reporter: Carl Reinke | Owner: (none) Type: defect | Status: open Priority: normal | Component: ffprobe Version: git-master | Resolution: Keywords: | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | -------------------------------------+----------------------------------- Comment (by Stefano Sabatini): Cannot reproduce with latest master f7dd408d64013ae177c1f8d0e04418e5075db5bc. Can you provide a sample reproducing this issue? This or we should mark this as resolved. -- Ticket URL: <https://trac.ffmpeg.org/ticket/7217#comment:4> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker
#7217: ffprobe produces wrong XML; "data_hash" attribute sometimes in text -------------------------------------+----------------------------------- Reporter: Carl Reinke | Owner: (none) Type: defect | Status: open Priority: normal | Component: ffprobe Version: git-master | Resolution: Keywords: | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | -------------------------------------+----------------------------------- Comment (by Balling): The file after redirect is here: https://http.hu.scene.org/music/groups/kahvicollective/kahvi048_pinza- thickline.ogg It still happens, data_hash="SHA160:5e0e1c526cd631e016e378bc99302e63ea40e381" should be in '''<packet codec_type="audio" data_hash="SHA160:5e0e1c526cd631e016e378bc99302e63ea40e381">''' -- Ticket URL: <https://trac.ffmpeg.org/ticket/7217#comment:5> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker
#7217: ffprobe produces wrong XML; "data_hash" attribute sometimes in text -------------------------------------+----------------------------------- Reporter: Carl Reinke | Owner: (none) Type: defect | Status: open Priority: normal | Component: ffprobe Version: git-master | Resolution: Keywords: | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | -------------------------------------+----------------------------------- Comment (by Stefano Sabatini): Thanks for the sample, I was able to reproduce, patch sent to ML. -- Ticket URL: <https://trac.ffmpeg.org/ticket/7217#comment:6> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker
#7217: ffprobe produces wrong XML; "data_hash" attribute sometimes in text -------------------------------------+----------------------------------- Reporter: Carl Reinke | Owner: (none) Type: defect | Status: open Priority: normal | Component: ffprobe Version: git-master | Resolution: Keywords: | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | -------------------------------------+----------------------------------- Comment (by Balling): https://patchwork.ffmpeg.org/project/ffmpeg/patch/20220807230356.659151-1-st... VERY NICE!!! -- Ticket URL: <https://trac.ffmpeg.org/ticket/7217#comment:7> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker
#7217: ffprobe produces wrong XML; "data_hash" attribute sometimes in text -------------------------------------+----------------------------------- Reporter: Carl Reinke | Owner: (none) Type: defect | Status: closed Priority: normal | Component: ffprobe Version: git-master | Resolution: fixed Keywords: | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | -------------------------------------+----------------------------------- Changes (by Stefano Sabatini): * status: open => closed * resolution: => fixed Comment: Replying to [comment:7 Balling]:
https://patchwork.ffmpeg.org/project/ffmpeg/patch/20220807230356.659151-1-st...
VERY NICE!!!
Sorry for the long wait, fixed in commit [https://git.ffmpeg.org/gitweb/ffmpeg.git/commit/843a4467131fd677aacb46b8bbde... 843a4467131fd677aacb46]. -- Ticket URL: <https://trac.ffmpeg.org/ticket/7217#comment:8> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker
participants (1)
-
FFmpeg