#3742(avcodec:new): Assertion when playing h264 with vlc using vdpau
#3742: Assertion when playing h264 with vlc using vdpau ------------------------------------+-------------------------------------- Reporter: oromit | Type: defect Status: new | Priority: normal Component: avcodec | Version: git-master Keywords: h264 vdpau | Blocked By: Blocking: | Reproduced by developer: 0 Analyzed by developer: 0 | ------------------------------------+-------------------------------------- When playing any h264 video in vlc(tested with version 2.1.4) using vdpau hwaccel, it aborts with the following assertion: Assertion desc->flags & (1 << 4) failed at libavcodec/utils.c:722 Bisecting the issue ended up on the following two commits: 5c1d7246cd65dc4db1b6dc36e29ce39fc1068f3f f2f99f07a5f1f74a91503cc6c3730c06498cee43 Playing h264 without vdpau acceleration works fine in vlc. So does playing it with ffplay. Also using the ffmpeg cli util with hwaccel vdpau works fine. -- Ticket URL: <https://trac.ffmpeg.org/ticket/3742> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker
#3742: Assertion when playing h264 with vlc using vdpau -------------------------------------+------------------------------------- Reporter: oromit | Owner: Type: defect | Status: new Priority: important | Component: avcodec Version: git-master | Resolution: Keywords: h264 vdpau | Blocked By: crash abort regression | Reproduced by developer: 0 Blocking: | Analyzed by developer: 0 | -------------------------------------+------------------------------------- Changes (by cehoyos): * keywords: h264 vdpau => h264 vdpau crash abort regression * priority: normal => important Comment: Which FFmpeg version did you test / is this reproducible with current FFmpeg git head? -- Ticket URL: <https://trac.ffmpeg.org/ticket/3742#comment:1> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker
#3742: Assertion when playing h264 with vlc using vdpau -------------------------------------+------------------------------------- Reporter: oromit | Owner: Type: defect | Status: new Priority: important | Component: avcodec Version: git-master | Resolution: Keywords: h264 vdpau | Blocked By: crash abort regression | Reproduced by developer: 0 Blocking: | Analyzed by developer: 0 | -------------------------------------+------------------------------------- Comment (by oromit): Yes, it still happens on current git master, which is where i first noticed it. I then went backwards until i found a commit that still worked, and then bisected between those, with the result i already posted. -- Ticket URL: <https://trac.ffmpeg.org/ticket/3742#comment:2> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker
#3742: Assertion when playing h264 with vlc using vdpau -------------------------------------+------------------------------------- Reporter: oromit | Owner: Type: defect | Status: new Priority: important | Component: avcodec Version: git-master | Resolution: Keywords: h264 vdpau | Blocked By: crash abort regression | Reproduced by developer: 0 Blocking: | Analyzed by developer: 0 | -------------------------------------+------------------------------------- Comment (by michael): Can someone try if patch below fixes it: {{{ diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c index 9e11038..2a67f4d 100644 --- a/libavcodec/pthread_frame.c +++ b/libavcodec/pthread_frame.c @@ -376,7 +376,7 @@ FF_ENABLE_DEPRECATION_WARNINGS p->result = ff_get_buffer(p->avctx, p->requested_frame, p->requested_flags); break; case STATE_GET_FORMAT: - p->result_format = p->avctx->get_format(p->avctx, p->available_formats); + p->result_format = ff_get_format(p->avctx, p->available_formats); break; default: call_done = 0; }}} -- Ticket URL: <https://trac.ffmpeg.org/ticket/3742#comment:3> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker
#3742: Assertion when playing h264 with vlc using vdpau -------------------------------------+------------------------------------- Reporter: oromit | Owner: Type: defect | Status: new Priority: important | Component: avcodec Version: git-master | Resolution: Keywords: h264 vdpau | Blocked By: crash abort regression patch | Reproduced by developer: 0 Blocking: | Analyzed by developer: 0 | -------------------------------------+------------------------------------- Changes (by michael): * keywords: h264 vdpau crash abort regression => h264 vdpau crash abort regression patch -- Ticket URL: <https://trac.ffmpeg.org/ticket/3742#comment:4> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker
#3742: Assertion when playing h264 with vlc using vdpau -------------------------------------+------------------------------------- Reporter: oromit | Owner: Type: defect | Status: new Priority: important | Component: avcodec Version: git-master | Resolution: Keywords: h264 vdpau | Blocked By: crash abort regression patch | Reproduced by developer: 0 Blocking: | Analyzed by developer: 0 | -------------------------------------+------------------------------------- Comment (by oromit): Yes, with this patch applied to the current ffmpeg master VLC 2.1.4 can play video with VDPAU acceleration again. -- Ticket URL: <https://trac.ffmpeg.org/ticket/3742#comment:5> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker
#3742: Assertion when playing h264 with vlc using vdpau -------------------------------------+------------------------------------- Reporter: oromit | Owner: Type: defect | Status: closed Priority: important | Component: avcodec Version: git-master | Resolution: fixed Keywords: h264 vdpau | Blocked By: crash abort regression patch | Reproduced by developer: 0 Blocking: | Analyzed by developer: 0 | -------------------------------------+------------------------------------- Changes (by michael): * status: new => closed * resolution: => fixed Comment: Patch applied Fixed in e36916a63f6fd0644461ecbd6b08eeb8dfab60ab thanks for testing -- Ticket URL: <https://trac.ffmpeg.org/ticket/3742#comment:6> FFmpeg <https://ffmpeg.org> FFmpeg issue tracker
participants (1)
-
FFmpeg