[Ffmpeg-cvslog] CVS: ffmpeg/libavcodec utils.c, 1.151, 1.152 avcodec.h, 1.419, 1.420 opt.c, 1.2, 1.3

Rich Felker dalias
Mon Sep 12 00:32:29 CEST 2005


On Sun, Sep 11, 2005 at 04:18:58PM +0300, Ivan Kalvachev wrote:
> 2005/9/11, Michael Niedermayer CVS <michael at mplayerhq.hu>:
> > Update of /cvsroot/ffmpeg/ffmpeg/libavcodec
> > In directory mail:/var2/tmp/cvs-serv1327/libavcodec
> > 
> > Modified Files:
> >         utils.c avcodec.h opt.c
> > Log Message:
> > AVOption API improvments
> > support AVOptions for encoding in ffmpeg.c
> > 
> 
> [...]
> 
> >  AVOption *av_next_option(void *obj, AVOption *last);
> > -
> > +int av_opt_show(void *obj, FILE *f);
> > 
> >  /**
> >   * AVCodec.
> 
> This FILE requires #include <stdio.h>
> (this was notices by g0th)

This is wtill broken, addinf stdio.h to opt.c does not fix it. IMO
making avcodec.h depend on stdio.h isn't acceptable. Instead why not
remove this function (which the caller can easily implement if it's a
command line prog that wants to print all options like that) or make
it use a callback to print each line, or return a huge string
containing all the options??

Rich





More information about the ffmpeg-cvslog mailing list