[Ffmpeg-cvslog] r7227 - trunk/libavcodec/dsputil.h

Panagiotis Issaris takis.issaris
Tue Dec 5 23:14:39 CET 2006


Hi,

On Tue, Dec 05, 2006 at 10:00:36PM +0000, M?ns Rullg?rd wrote:
> > [...]
> > +    /* h264 functions */
> >      void (*h264_idct_add)(uint8_t *dst, DCTELEM *block, int stride);
> >      void (*h264_idct8_add)(uint8_t *dst, DCTELEM *block, int stride);
> >      void (*h264_idct_dc_add)(uint8_t *dst, DCTELEM *block, int stride);
> 
> Isn't it fairly obvious from the names of those functions that they
> deal with H.264?  
Sure. I only did this for consistency with the other parts in that struct (vc1,
snow, avs, huffyuv, ...).

> Redundant comments are IMHO only slightly worse than
> incorrect comments.
I hope you mean the other way around... surely I think that incorrect comments
are much worse then redundant ones. 

With friendly regards,
Takis




More information about the ffmpeg-cvslog mailing list