[Ffmpeg-cvslog] r7227 - trunk/libavcodec/dsputil.h

Måns Rullgård mru
Tue Dec 5 23:20:21 CET 2006

Panagiotis Issaris <takis.issaris at uhasselt.be> writes:

> Hi,
> On Tue, Dec 05, 2006 at 10:00:36PM +0000, M?ns Rullg?rd wrote:
>> > [...]
>> > +    /* h264 functions */
>> >      void (*h264_idct_add)(uint8_t *dst, DCTELEM *block, int stride);
>> >      void (*h264_idct8_add)(uint8_t *dst, DCTELEM *block, int stride);
>> >      void (*h264_idct_dc_add)(uint8_t *dst, DCTELEM *block, int stride);
>> Isn't it fairly obvious from the names of those functions that they
>> deal with H.264?  
> Sure. I only did this for consistency with the other parts in that
> struct (vc1, snow, avs, huffyuv, ...).

I see.  By all means leave it.  It's not likely to confuse anyone.  If
I see a lengthy comment next to a piece of code, it makes me assume
that there is something about the code that isn't obvious.  If the
comment then simply says the code does what it appears to be doing,
reading it is a waste of time in the best case, and confusing in the
worse cases.

>> Redundant comments are IMHO only slightly worse than incorrect
>> comments.
> I hope you mean the other way around... surely I think that
> incorrect comments are much worse then redundant ones.

Yes, of course I did.  Thinking one thing, writing another again...

M?ns Rullg?rd
mru at inprovide.com

More information about the ffmpeg-cvslog mailing list