[Ffmpeg-cvslog] r7282 - in trunk/libavcodec: Makefile dsputil.c h264dsp.c

Måns Rullgård mru
Mon Dec 11 16:59:11 CET 2006

takis said:

> +#if defined(CONFIG_H264_ENCODER)
> +/* H264 specific */
> +void ff_h264dsp_init(DSPContext* c, AVCodecContext *avctx);
> +#endif /* CONFIG_H264_ENCODER */

IMHO we shouldn't have #ifdef around prototypes for extern functions.  It only
adds clutter without serving any real purpose.  Having a prototype for a
function that doesn't exist doesn't do any harm.

A prototype for a static function that is never defined triggers a warning
(of arguable usefulness).  OTOH, static functions should preferably be ordered
such that no prototypes are needed, if possible.

M?ns Rullg?rd
mru at inprovide.com

More information about the ffmpeg-cvslog mailing list