[Ffmpeg-cvslog] r7275 - trunk/libavcodec/dsputil.c

Måns Rullgård mru
Tue Dec 12 00:54:26 CET 2006

The Wanderer <inverseparadox at comcast.net> writes:

> M?ns Rullg?rd wrote:
>> The Wanderer said:
>>> mru wrote:
>>>> Log:
>>>> improved stack misalignment warning
>>>> -                "so reporting it anywhere but to the compiler maintainers is senseless!\n");
>>>> +                "Compiler did not align stack variables. Libavcodec has been miscompiled\n"
>>>> +                "and may be very slow or crash. This is not a bug in libavcodec,\n"
>>>> +                "but in the compiler. Do not report crashes to FFmpeg developers.\n");
>>> Remaining (possibly new) errors:
>>> "Libavcodec" instead of "libavcodec" - the name is correctly
>>> lowercase, being at the beginning of a sentence makes no
>>> difference.
>> I wasn't aware that the naming of these libraries was that strict.
> The naming of these libraries in particular probably isn't. I apply that
> policy to all libraries, and all personal names, and all place names,
> and so forth. Capitalization is part of the spelling of any name, and
> varying it based on position is incorrect.

I'd argue that some names follow the same rules as regular words,
i.e. they are capitalized at the beginning of a sentence.  I'd also
argue that the libav* names fall into this category.  The names are
not typically used in a case sensitive context as, for instance, names
of library functions normally are.  Thus they should be subjected to
the rules of normal given names (always capitalized) or those of
regular words (capitalized sometimes).

> I acknowledge, for the record, that this is my own position and is not
> the accepted practice of the world (or even of grammarians in
> general)... but to see any name capitalized when it ordinarily is not
> grates on me at least as much as to see a name left uncapitalized when
> it ordinarily is, and I am campaigning - in my generally lazy way - to
> change common practice.
> (For a possible comparison, how wrong would it seem to you to see it
> called - say - "LibAvCodec"?)

That is just outrageously, hideously, dreadfully ugly.  It looks like
something a Java programmer might write.

M?ns Rullg?rd
mru at inprovide.com

More information about the ffmpeg-cvslog mailing list