[Ffmpeg-cvslog] CVS: ffmpeg qt-faststart.c,1.5,1.6

Mike Melanson mike
Fri Mar 17 00:59:57 CET 2006


Baptiste Coudurier CVS wrote:
> Update of /cvsroot/ffmpeg/ffmpeg
> In directory mail:/var2/tmp/cvs-serv8734
> 
> Modified Files:
> 	qt-faststart.c 
> Log Message:
> 
>>2GB file fix
> 
> 
> Index: qt-faststart.c
> ===================================================================
> RCS file: /cvsroot/ffmpeg/ffmpeg/qt-faststart.c,v
> retrieving revision 1.5
> retrieving revision 1.6
> diff -u -d -r1.5 -r1.6
> --- qt-faststart.c	16 Mar 2006 16:37:05 -0000	1.5
> +++ qt-faststart.c	16 Mar 2006 23:57:40 -0000	1.6
> @@ -99,7 +99,7 @@
>          if (fread(atom_bytes, ATOM_PREAMBLE_SIZE, 1, infile) != 1) {
>              break;
>          }
> -        atom_size = BE_32(&atom_bytes[0]);
> +        atom_size = (uint32_t)BE_32(&atom_bytes[0]);
>          atom_type = BE_32(&atom_bytes[4]);
>  
>          if ((atom_type != FREE_ATOM) &&

	You ran all those other patches by me first, why not this one? This 
strikes me as unnecessary. BE_32 should do the right thing without 
extraneous casting.

-- 
	-Mike Melanson





More information about the ffmpeg-cvslog mailing list