[Ffmpeg-cvslog] r6963 - trunk/libavformat/riff.c

[Baptiste Coudurier]

Hi

Michael Niedermayer a ?crit :
> Hi
> 
> On Sat, Nov 11, 2006 at 01:22:08AM +0000, M?ns Rullg?rd wrote:
>> michael <subversion at mplayerhq.hu> writes:
>>
>>> Author: michael
>>> Date: Sat Nov 11 01:29:49 2006
>>> New Revision: 6963
>>>
>>> Modified:
>>>    trunk/libavformat/riff.c
>>>
>>> Log:
>>> libnut uses "MP3 " for mp3
>>>
>>> Modified: trunk/libavformat/riff.c
>>> ==============================================================================
>>> --- trunk/libavformat/riff.c	(original)
>>> +++ trunk/libavformat/riff.c	Sat Nov 11 01:29:49 2006
>>> @@ -200,6 +200,7 @@
>>>      // for NuppelVideo (nuv.c)
>>>      { CODEC_ID_PCM_S16LE, MKTAG('R', 'A', 'W', 'A') },
>>>      { CODEC_ID_MP3, MKTAG('L', 'A', 'M', 'E') },
>>> +    { CODEC_ID_MP3, MKTAG('M', 'P', '3', ' ') },
>> Nooooo.  We were trying to get rid of those invalid bogus tags from
>> riff.c.  Don't add more of them.
> 
> nut per spec uses the avi-riff tags to identify codecs, libnut uses
> "MP3 " ...
 > ask oded why
 > but the nut tags do belong in riff.c IMO, furthermore there is no harm
 > from this wav/avi cant use them anyway as they are too long, also they
 > are at the end so they wont be selected by default ...
 >

IMHO, nut uses fourcc, aka 32 bit int that is supposed to identify a 
codec, not avi-riff tags, nut fourccs use may avi ones but still nut 
needs his own table, since it does not use WAVEFORMATEX nor 
BITMAPINFOHEADER, riff.c is only there to avoid duplicating the table 
for avi, asf and wav.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no