[Ffmpeg-cvslog] r7050 - in trunk: configure libavutil/common.h

Måns Rullgård mru
Tue Nov 14 14:30:05 CET 2006


*@reimardoeffinger.de said:
>>
>>-#ifndef EMULATE_INTTYPES
>>+#ifdef HAVE_INTTYPES
>> #   include <inttypes.h>
>> #else
>
> This seems like a really bad idea to me, since this header is for use by external
> programs AFAIK, which means that
> 1) previous code would at worst fail because of missing inttypes.h, like this it
> might use incorrect typedefs
> 2) Such a change in a public header IMHO is an API change.

It is no more broken now than it used to be.  Conditional things like this simply
do not belong in public headers at all.

Are there any systems still missing inttypes.h?  IIRC this was added for some
old version of cygwin.  Modern cygwin versions have inttypes.h.

-- 
M?ns Rullg?rd
mru at inprovide.com




More information about the ffmpeg-cvslog mailing list