[Ffmpeg-cvslog] r7050 - in trunk: configure libavutil/common.h

[Diego Biurrun]

On Tue, Nov 14, 2006 at 02:25:24PM +0000, M?ns Rullg?rd wrote:
> 
> Diego Biurrun said:
> > On Tue, Nov 14, 2006 at 01:30:05PM +0000, M?ns Rullg?rd wrote:
> >>
> >> *@reimardoeffinger.de said:
> >> >>
> >> >>-#ifndef EMULATE_INTTYPES
> >> >>+#ifdef HAVE_INTTYPES
> >> >> #   include <inttypes.h>
> >> >> #else
> >> >
> >> > This seems like a really bad idea to me, since this header is for use by
> >> external
> >> > programs AFAIK, which means that
> >> > 1) previous code would at worst fail because of missing inttypes.h, like this
> >> it
> >> > might use incorrect typedefs
> >> > 2) Such a change in a public header IMHO is an API change.
> >>
> >> It is no more broken now than it used to be.  Conditional things like this simply
> >> do not belong in public headers at all.
> >>
> >> Are there any systems still missing inttypes.h?  IIRC this was added for some
> >> old version of cygwin.  Modern cygwin versions have inttypes.h.
> >
> > I think libc5 systems don't have inttypes.h.  Whether we need/want to
> > support these is an open question of course.
> 
> I haven't seen one of those in many years.  Even Debian stable uses glibc2 so
> I doubt there are still any libc5 based systems being maintained.
> 
> IMHO requiring a system less than 10 years old is reasonable for any moderately
> complex piece of software.

Fine with me, what do the others say?

Diego