[Ffmpeg-cvslog] r6213 - in trunk: Changelog MAINTAINERS doc/ffmpeg-doc.texi libavcodec/Makefile libavcodec/allcodecs.c libavcodec/avcodec.h libavcodec/vp5.c libavcodec/vp56.c libavcodec/vp56.h libavcodec/vp56data.c libavcodec/vp56data.h libavcodec/vp5data.h libavcodec/vp6.c libavcodec/vp6data.h libavformat/flvdec.c libavformat/nsvdec.c libavformat/riff.c libavformat/swf.c

[Baptiste Coudurier]

Hi

Benjamin Larsson wrote:
> Baptiste Coudurier wrote:
> 
>> Hi
>>
>> Thanks for the great job.
>>
>> aurel wrote:
>>  
>>
>>> [...]
>>> @@ -121,6 +121,9 @@
>>>     CODEC_ID_CAVS,
>>>     CODEC_ID_JPEG2000,
>>>     CODEC_ID_VMNC,
>>> +    CODEC_ID_VP5,
>>> +    CODEC_ID_VP6,
>>> +    CODEC_ID_VP6F,
>>>
>>>    
>>>
>> Is defining a new codec id the only way to identify VP6 in flash ? It
>> seems it uses the same function to decode. Why not using CODEC_ID_VP6 ?
>>
>>  
>>
> The there is a horizontally flipped relation between them. And there
> isn't a clean way of joining them to one codec id so the simplest
> solution is to use 2 id's.
> 
> MvH
> Benjamin Larsson
> 

Humm, it seems this issue has been discussed already. What was decided ?
I can't get if it was decided to use a new codec id or not.

Personnaly I don't like that VP6F codec id. I would be more in favor of
setting a field or sub id or a flag in avctx, or maybe put those 2 bytes
from the flv in extradata or something to identify it.

What do you guys think ?

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312