[Ffmpeg-cvslog] r8767 - trunk/libavcodec/raw.c

[Måns Rullgård]

Alex Beregszaszi <alex at rtfs.hu> writes:

> Hi,
>
>> Modified: trunk/libavcodec/raw.c
>> ==============================================================================
>> --- trunk/libavcodec/raw.c	(original)
>> +++ trunk/libavcodec/raw.c	Sat Apr 21 02:47:55 2007
>> @@ -212,6 +212,7 @@ AVCodec rawvideo_encoder = {
>>  };
>>  #endif // CONFIG_RAWVIDEO_ENCODER
>>  
>> +#ifdef CONFIG_RAWVIDEO_DECODER
>>  AVCodec rawvideo_decoder = {
>>      "rawvideo",
>>      CODEC_TYPE_VIDEO,
>> @@ -222,3 +223,4 @@ AVCodec rawvideo_decoder = {
>>      raw_close_decoder,
>>      raw_decode,
>>  };
>> +#endif // CONFIG_RAWVIDEO_DECODER
>
> I know the more elegant solution is to change the Makefile, however,
> there is an exported function (avcodec_pix_fmt_to_codec_tag) in raw.c.

That is madness.  Anything codec tag related belongs in lavf.  The
value it returns is valid only for some containers.  It should be
moved to an appropriate file in lavf (probably riff.c), and the avi
muxer should call it when muxing raw video.

-- 
M?ns Rullg?rd
mans at mansr.com