[FFmpeg-cvslog] r9848 - trunk/libavcodec/ac3dec.c

[Benjamin Larsson]

Uoti Urpala skrev:
> On Wed, 2007-08-01 at 07:39 +0200, Benjamin Larsson wrote:
>   
>> jbr wrote:
>>     
>>>  static void do_imdct_256(AC3DecodeContext *ctx, int chindex)
>>>  {
>>>      int i, k;
>>> -    float x[128];
>>> +    DECLARE_ALIGNED_16(float, x[128]);
>>>      FFTComplex z[2][64];
>>>      float *o_ptr = ctx->tmp_output;
>>>       
>> This wont work on win32/beos with regular gcc's. Please use an array
>> allocated in the AC3DecodeContext.
>>     
>
> What do you mean by "with regular gccs"? And why would it fail? I don't
> see anything special about this case - if you're talking about the same
> "other code misaligns stack and no forced realign was used" or "old
> buggy gcc version was used" issues then those already occur elsewhere in
> the code.
>
>   

DECLARE_ALIGNED doesn't work on win32 on stack variables. I guess that falls into the old buggy gcc version was used case.

MvH
Benjamin Larsson