[FFmpeg-cvslog] r10105 - trunk/libavcodec/bfin/dsputil_bfin.c

Michael Niedermayer michaelni
Tue Aug 14 01:38:28 CEST 2007


Hi

On Mon, Aug 13, 2007 at 04:16:21PM +0200, mhoffman wrote:
> Author: mhoffman
> Date: Mon Aug 13 16:16:20 2007
> New Revision: 10105
> 
> Log:
> special handling for vp3 idct, use the c reference
> 
> Modified:
>    trunk/libavcodec/bfin/dsputil_bfin.c
> 
> Modified: trunk/libavcodec/bfin/dsputil_bfin.c
> ==============================================================================
> --- trunk/libavcodec/bfin/dsputil_bfin.c	(original)
> +++ trunk/libavcodec/bfin/dsputil_bfin.c	Mon Aug 13 16:16:20 2007
> @@ -279,10 +279,12 @@ void dsputil_init_bfin( DSPContext* c, A
>      c->put_no_rnd_pixels_tab[0][3] = ff_bfin_put_pixels16_xy2_nornd;
>  
>      c->idct_permutation_type = FF_NO_IDCT_PERM;
> -    c->fdct               = ff_bfin_fdct;
> -    c->idct               = ff_bfin_idct;
> -    c->idct_add           = bfin_idct_add;
> -    c->idct_put           = bfin_idct_put;
> +    c->fdct                  = ff_bfin_fdct;
> +    if (avctx->idct_algo!=FF_IDCT_VP3) {
> +        c->idct               = ff_bfin_idct;
> +        c->idct_add           = bfin_idct_add;
> +        c->idct_put           = bfin_idct_put;
> +    }
>  }

ideg, this is broken
you must _NOT_ set *dct to anything except what the user asks for
if idct_algo == FF_IDCT_AUTO then set it to any accurate enough 
implementation
if its not FF_IDCT_AUTO you have to set it to what the user asks for
or keep your fingers off the variable

i guess there are not enough bfin users to notice that this breaks
playback of quite a bit more then just vp3 ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20070814/78c1d207/attachment.pgp>



More information about the ffmpeg-cvslog mailing list