[FFmpeg-cvslog] r11225 - trunk/libavformat/avformat.h

Måns Rullgård mans
Mon Dec 17 00:40:05 CET 2007


Diego Biurrun <diego at biurrun.de> writes:

> On Sun, Dec 16, 2007 at 10:52:23PM +0000, M?ns Rullg?rd wrote:
>> Michael Niedermayer <michaelni at gmx.at> writes:
>> 
>> > On Sun, Dec 16, 2007 at 06:22:09PM +0100, Diego Biurrun wrote:
>> >> On Sat, Dec 15, 2007 at 05:54:59PM +0100, michael wrote:
>> >> > 
>> >> > Log:
>> >> > document how to free the result of av_alloc_format_context()
>> >> > 
>> >> > --- trunk/libavformat/avformat.h	(original)
>> >> > +++ trunk/libavformat/avformat.h	Sat Dec 15 17:54:58 2007
>> >> > @@ -569,7 +569,11 @@ int av_open_input_file(AVFormatContext *
>> >> > +/**
>> >> > + * Allocate an AVFormatContext.
>> >> > + * can be freed with av_free() but dont forget to free everything you
>> >> > + * explicitly allocated as well!
>> >> 
>> >> Could you please make an effort to avoid obvious misspellings ("dont")?
>> >> It took some work to fix these things up in FFmpeg and it would be a
>> >> pity to let it go to waste again.
>> >
>> > feel free to improve the precommit check script
>> 
>> I have to say, this attitude of yours is starting to get quite tiresome.
>
> Very much so.  I don't understand why you are such a complete perfectionist
> about what code is acceptable for FFmpeg and at the same time disregard
> the quality of the (Doxygen) documentation.

How about we start committing random broken code with the excuse that
"Michael will fix it"?

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-cvslog mailing list