[Ffmpeg-cvslog] r7392 - trunk/libavformat/mpc.c

[Michael Niedermayer]

Hi

On Mon, Jan 01, 2007 at 02:23:17PM +0100, Alex Beregszaszi wrote:
> Hi,
> 
> > > --- trunk/libavformat/mpc.c	(original)
> > > +++ trunk/libavformat/mpc.c	Mon Jan  1 06:29:53 2007
> > > @@ -45,6 +45,8 @@
> > >          return 0;
> > >      if (d[0] == 'M' && d[1] == 'P' && d[2] == '+' && (d[3] == 0x17 || d[3] == 0x7))
> > >          return AVPROBE_SCORE_MAX;
> > > +    if (d[0] == 'I' && d[1] == 'D' && d[2] == '3')
> > > +        return AVPROBE_SCORE_MAX / 2;
> > 
> > doesnt this conflict with .mp3 ?
> 
> MP3 should return higher score for this. 

yes which causes a conflict in the sense that the above change does
not have any effect at all ...


> However, lot of crappy lossless
> formats (Monkeys audio) use ID3 tags in the beginning.

IIRC i have a mpeg-ps with id3 tag at the begin too

maybe we should have a generic skip_id3() function which then could be 
called from mpc_probe() mp3_probe() and so on before the real probe code

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20070101/0da468d3/attachment.pgp>