[Ffmpeg-cvslog] r7729 - in trunk: configure libavcodec/cabac.h

Guillaume POIRIER poirierg
Sat Jan 27 21:59:43 CET 2007


Hi,

On 1/27/07, mru <subversion at mplayerhq.hu> wrote:
> Author: mru
> Date: Sat Jan 27 15:10:57 2007
> New Revision: 7729
>
> Modified:
>    trunk/configure
>    trunk/libavcodec/cabac.h
>
> Log:
> rename CMOV_IS_FAST to HAVE_FAST_CMOV and simplify configure

To me, knowing that CMOV is supported, and the fact that it's fast,
are two different things.

I can't think of an example right now to show when it could be
profitable to use cmov even though it's slow, but if I understood
correctly your change, P4 user will now use suboptimal CABAC code
because they use an ASM code that depends on having a fast
implementation of CMOV.

Other than simplifying configure script, were there a reason to make
the change your did?

If not, I think this needs to be reverted, though I'd prefer to hear
what Michael may have to say about this.

Guillaume




More information about the ffmpeg-cvslog mailing list