[FFmpeg-cvslog] r9581 - in trunk/libavcodec: dsputil.c h263.h i386/dsputil_mmx.c mpegvideo_enc.c msmpeg4.h

[Ramiro Ribeiro Polla]

Aurelien Jacobs wrote:

>On Tue, 10 Jul 2007 18:30:37 -0300
>Ramiro Ribeiro Polla <ramiro at lisha.ufsc.br> wrote:
>
>  
>
>>aurel wrote:
>>    
>>
>>>Author: aurel
>>>Date: Tue Jul 10 22:23:08 2007
>>>New Revision: 9581
>>>
>>>Log:
>>>Avoid linking with h263.c functions when the relevant codecs
>>>are not compiled in.
>>>
>>>  
>>>      
>>>
>>There are still some missing in libavcodec/dsputil.c, and 
>>libavcodec/i386/dsputil_mmx.c (and possibly on other arches I haven't 
>>looked).
>>
>>ramiro at drake:/usrc/ffmpeg/build$ ../src/configure --disable-muxers 
>>--disable-parsers --disable-demuxers --disable-encoders 
>>--disable-decoders --disable-bsfs
>>ramiro at drake:/usrc/ffmpeg/build$ make
>>[builds everything and gives this error:]
>>ramiro at drake:/usrc/ffmpeg/build$ make
>>    
>>
[error linking due to ff_h263_loop_filter_strength]

>Sorry, I can't reproduce this. Could you try a make clean first ?
>
>  
>

Reproduced on another machine.
Fresh checkout:
[ramiro at aspect build]$ ../src/configure --disable-parsers 
--disable-muxers --disable-demuxers --disable-encoders 
--disable-decoders --disable-bsfs
[ramiro at aspect build]$ make
[...]
gcc -L"/export/ramiro/ffmpeg/build"/libavformat 
-L"/export/ramiro/ffmpeg/build"/libavcodec 
-L"/export/ramiro/ffmpeg/build"/libavutil -rdynamic -export-dynamic 
-Wl,--warn-common -Wl,--as-needed 
-Wl,-rpath-link,"/export/ramiro/ffmpeg/build"/libavcodec 
-Wl,-rpath-link,"/export/ramiro/ffmpeg/build"/libavformat 
-Wl,-rpath-link,"/export/ramiro/ffmpeg/build"/libavutil -g -o ffmpeg_g 
ffmpeg.o cmdutils.o -lavformat -lavcodec -lavutil -lm -lz -ldl
/export/ramiro/ffmpeg/build/libavcodec/libavcodec.a(dsputil.o)(.text+0x9592): 
In function `h263_v_loop_filter_c':
/export/ramiro/ffmpeg/src/libavcodec/dsputil.c:2645: undefined reference 
to `ff_h263_loop_filter_strength'
/export/ramiro/ffmpeg/build/libavcodec/libavcodec.a(dsputil.o)(.text+0x10be6): 
In function `h263_h_loop_filter_c':
/export/ramiro/ffmpeg/src/libavcodec/dsputil.c:2680: undefined reference 
to `ff_h263_loop_filter_strength'
/export/ramiro/ffmpeg/build/libavcodec/libavcodec.a(dsputil_mmx.o)(.text+0x1804): 
In function `h263_v_loop_filter_mmx':
/export/ramiro/ffmpeg/src/libavcodec/i386/dsputil_mmx.c:627: undefined 
reference to `ff_h263_loop_filter_strength'
/export/ramiro/ffmpeg/build/libavcodec/libavcodec.a(dsputil_mmx.o)(.text+0x416cd): 
In function `h263_h_loop_filter_mmx':
/export/ramiro/ffmpeg/src/libavcodec/i386/dsputil_mmx.c:673: undefined 
reference to `ff_h263_loop_filter_strength'
collect2: ld returned 1 exit status
make: ** [ffmpeg_g] Erro 1

Shouldn't h263_v_loop_filter_c and h263_h_loop_filter_c also be under 
any h263?

Ramiro Polla
Btw, great job making these parts conditional. The resulting dll is 
getting smaller and smaller when only a few select codecs are enabled. 
motion_est was huge =)