[Ffmpeg-cvslog] r8204 - trunk/libavformat/mov.c

Michael Niedermayer michaelni
Sat Mar 3 21:31:39 CET 2007


Hi

On Sat, Mar 03, 2007 at 08:48:35PM +0100, Baptiste Coudurier wrote:
> Michael Niedermayer wrote:
> > Hi
> > 
> > On Sat, Mar 03, 2007 at 01:30:29PM -0500, The Wanderer wrote:
> >> bcoudurier wrote:
> >>
> >>> Author: bcoudurier
> >>> Date: Sat Mar  3 15:33:55 2007
> >>> New Revision: 8204
> >>>
> >>> Modified:
> >>>   trunk/libavformat/mov.c
> >>>
> >>> Log:
> >>> cosmetics, cleanup tables, add pcm 24/32 le tags
> >> Isn't that a mix of functional and cosmetic changes?
> > 
> > sounds like it is, so it should be reverted (ill revert it if baptiste
> > doesnt) and then be commited as a seperate cosmetics only and 
> > non cosmetic change
> > 
> 
> Humm, is that a game/joke or something ?

no


> You going to revert it for 2 lines of fourccs even more when those 2
> lines are mentioned in the commit log ?

yes


> I think that whole Uoti story
> has made some people mad.

not really, search svn log ive always flamed everyone who did such things

and anyway its just 5min work to revert this and split the 2 lines out
btw, i didnt even realize that its 2 lines and that exactly is the problem
with such commits you never know what really has been changed if cosmetics
get mixed with functional changes

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20070303/f4f260c0/attachment.pgp>



More information about the ffmpeg-cvslog mailing list