[FFmpeg-cvslog] r8886 - in trunk/libavcodec: vc1.h vc1_parser.c

[Aurelien Jacobs]

On Fri, 4 May 2007 14:40:04 +0200
Diego Biurrun <diego at biurrun.de> wrote:

> On Fri, May 04, 2007 at 02:31:40PM +0200, kostya wrote:
> > 
> > Log:
> > 100l to myself. Do not include stuff unneeded by parser
> > 
> > --- trunk/libavcodec/vc1.h	(original)
> > +++ trunk/libavcodec/vc1.h	Fri May  4 14:31:40 2007
> > @@ -35,6 +35,7 @@ enum VC1Code{
> >  
> >  #define IS_MARKER(x) (((x) & ~0xFF) == VC1_CODE_RES0)
> >  
> > +#ifndef VC1_PARSER_ONLY
> >  /** Available Profiles */
> >  //@{
> >  enum Profile {
> > 
> > --- trunk/libavcodec/vc1_parser.c	(original)
> > +++ trunk/libavcodec/vc1_parser.c	Fri May  4 14:31:40 2007
> > @@ -26,6 +26,7 @@
> >  #include "dsputil.h"
> >  #include "parser.h"
> > +#define VC1_PARSER_ONLY
> >  #include "vc1.h"
> 
> That's very ugly, why not simply move the enum Profile to vc1.c?  Is it
> used in another place?

I agree that it's very ugly.
Moreover, the static tables in a header that is included from multiple
files are ugly too. IMO, those tables should be moved in their own .c
file.
But before proposing such a patch, may I first svn mv vc1.c vc1dec.c ?
(This would make room for a vc1.c containing shared code for encoder
and decoder, and would be cleaner if a vc1enc.c is ever included)

Aurel