[FFmpeg-cvslog] r8916 - in trunk/libavcodec: vc1.c vc1data.c vc1data.h

[matthieu castet]

Michael Niedermayer wrote:
> On Sun, May 06, 2007 at 01:40:42PM +0200, kostya wrote:
> 
> a vc1_ prefix is insufficient for global variables, they should have
> a ffmpeg/libavcodec specific prefix, that is ff_ for internal variables
> a prefix like vc1_ or ac3_ would not prevent name clashes with other
> implementations of the same codec and such other implementations are the
> most likely things where name clashes would occur ...
>
As for better modularity more and more static variables become global. 
Couldn't we introduce a __attribute__visibility_hiden for the compilers 
that support it ?

That way we could avoid some symbol clashes.

Of course the variable should still prefixed


Matthieu