[FFmpeg-cvslog] r8960 - trunk/libavcodec/pcm.c

Michael Niedermayer michaelni
Thu May 10 01:58:51 CEST 2007


On Thu, May 10, 2007 at 01:08:01AM +0200, ramiro wrote:
> Author: ramiro
> Date: Thu May 10 01:08:01 2007
> New Revision: 8960
> Log:
> Factorize usum

are you pcm.c maintainer? no?
did you send a patch? no?
is this change doing anything good besides bloating the code?
did you benchmark the code?

if the change would make sense i wouldnt mind if you commited without
sending a patch but it doesnt, at least its not obvious what good it does

these functions are static inline and the compiler will if it inlines
them optimize the check away, and the functions are small so i guess
gcc will inline them


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20070510/8382e793/attachment.pgp>

More information about the ffmpeg-cvslog mailing list