[FFmpeg-cvslog] r8985 - in trunk: configure libavcodec/Makefile libavcodec/cabac.h libavcodec/h264.c libavcodec/h264.h libavcodec/h264_parser.c libavcodec/h264_parser.h

Diego Biurrun diego
Fri May 11 10:19:28 CEST 2007


On Fri, May 11, 2007 at 09:09:07AM +0100, M?ns Rullg?rd wrote:
> Diego Biurrun <diego at biurrun.de> writes:
> 
> > On Fri, May 11, 2007 at 08:47:52AM +0100, M?ns Rullg?rd wrote:
> >> Diego Biurrun <diego at biurrun.de> writes:
> >> 
> >> > On Fri, May 11, 2007 at 12:26:44AM +0200, aurel wrote:
> >> >> 
> >> >> Log:
> >> >> split h264.c to move parser in its own file
> >> >
> >> > I had an identical change in my local tree, oh well ...
> >> >
> >> >> Added:
> >> >>    trunk/libavcodec/h264.h
> >> >>       - copied, changed from r8983, /trunk/libavcodec/h264.c
> >> >>    trunk/libavcodec/h264_parser.c
> >> >>       - copied, changed from r8983, /trunk/libavcodec/h264.c
> >> >>    trunk/libavcodec/h264_parser.h
> >> >>       - copied, changed from r8983, /trunk/libavcodec/h264.c
> >> >
> >> > Copying h264_parser.h is overkill IMO, they basically just share the
> >> > license header.
> >> 
> >> Git labels that file as copied with 70% similarity from
> >> mpeg4video_parser.h.
> >
> > So much for git's copy "autodetection" ...
> 
> You said yourself only the license header was in common with h264.c.
> It doesn't really make sense calling it a copy in that case.  OTOH,
> diff it with mpeg4video_parser.h and see how similar they are.

I know.  I just don't think automating these things makes much sense.

Diego




More information about the ffmpeg-cvslog mailing list