[FFmpeg-cvslog] r10889 - trunk/libavcodec/allcodecs.c

[Michael Niedermayer]

Hi

On Wed, Oct 31, 2007 at 11:55:46PM +0100, Aurelien Jacobs wrote:
> michael wrote:
> 
> > Author: michael
> > Date: Wed Oct 31 23:39:10 2007
> > New Revision: 10889
> > 
> > Log:
> > prefer our native vorbis decoder over libvorbis
> 
> It also affect encoder...
> And libvorbis encoder is certainly preferred over the native one.

hum why?

dont you want someone to fix it so its quality is better than libvorbis?


> 
> > Modified:
> >    trunk/libavcodec/allcodecs.c
> > 
> > Modified: trunk/libavcodec/allcodecs.c
> > ==============================================================================
> > --- trunk/libavcodec/allcodecs.c	(original)
> > +++ trunk/libavcodec/allcodecs.c	Wed Oct 31 23:39:10 2007
> > @@ -191,7 +191,6 @@ void avcodec_register_all(void)
> >      REGISTER_ENCDEC  (LIBGSM_MS, libgsm_ms);
> >      REGISTER_ENCODER (LIBMP3LAME, libmp3lame);
> >      REGISTER_ENCODER (LIBTHEORA, libtheora);
> > -    REGISTER_ENCDEC  (LIBVORBIS, libvorbis);
> >      REGISTER_DECODER (MACE3, mace3);
> >      REGISTER_DECODER (MACE6, mace6);
> >      REGISTER_ENCDEC  (MP2, mp2);
> > @@ -215,6 +214,7 @@ void avcodec_register_all(void)
> >      REGISTER_ENCDEC  (WMAV1, wmav1);
> >      REGISTER_ENCDEC  (WMAV2, wmav2);
> >      REGISTER_DECODER (WS_SND1, ws_snd1);
> > +    REGISTER_ENCDEC  (LIBVORBIS, libvorbis);
> 
> I don't like this change very much...

yes yes, i expected flames
thanks for proofing that i guessed right ;)


> Default ./configure will enable native vorbis and disable libvorbis.
> If user intentionally enable libvorbis, that's probably because he
> want to use it. Thus it should probably be preferred over vorbis.

i use --enable-libvorbis but dont want it used by default, what should i
do?
also binaries from distros will likely have it enabled by default and that
might not match what the user wants to use by default


> 
> Oh, and the best way to fix this anyway is to drop support for
> libvorbis decoding ;-)

that would make debuging the decoder harder, so feel free to drop it
after you overtook maintainership of our vorbis decoder :)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20071101/0789d78d/attachment.pgp>