[FFmpeg-cvslog] r10823 - in trunk/libavformat: rm.h rmdec.c

Michael Niedermayer michaelni
Thu Nov 1 16:54:45 CET 2007


On Thu, Nov 01, 2007 at 12:10:58AM -0400, Rich Felker wrote:
> On Wed, Oct 31, 2007 at 10:39:35PM +0100, Michael Niedermayer wrote:
> > Hi
> > 
> > On Sun, Oct 21, 2007 at 07:17:28PM +0200, kostya wrote:
> > > Author: kostya
> > > Date: Sun Oct 21 19:17:28 2007
> > > New Revision: 10823
> > > 
> > > Log:
> > > Demux full frames instead of sliced for RealVideo.
> > > Some changes by Roberto Togni and blessed by him on IRC.
> > 
> > i will revert this and the later patches depending on it in 24h if noone
> > fixes the rm/rv regression tests failure this change caused
> 
> please don't. if there are bugs they should be fixed asap, but this
> code is the direction forward and reverting it will just be a mess...

no, there where 10 days time to fix it and there was already a commit
to the mov muxer which changed the regression checksums with no update
of them as people could no longer run the regression tests to check
anything or notice further breakage

now the regression tests mostly work again so ill wait more but none the
less if the seek regression test doesnt get fixed ill revert the 3-5
commits involved

knowingly breaking code due to some new and important feature has never
been ok i dont see why this should be an exception
and running the regression tests before commits (or at least fixing any
breakage of them ASAP afterwards) is part of the policy IIRC

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20071101/8bf71686/attachment.pgp>



More information about the ffmpeg-cvslog mailing list