[FFmpeg-cvslog] r10640 - in trunk/libavcodec: Makefile dsputil.h imgresample.c ppc/check_altivec.c ppc/dsputil_altivec.c ppc/dsputil_altivec.h ppc/fft_altivec.c ppc/gmc_altivec.c ppc/h264_altivec.c ppc/imgresample_altivec.c ppc/imgresample_altivec.h ppc/mpegvideo_altivec.c ppc/util_altivec.h ppc/vc1dsp_altivec.c

[Reimar Döffinger]

Hello,
On Tue, Oct 02, 2007 at 01:45:00PM +0200, Diego Biurrun wrote:
> On Tue, Oct 02, 2007 at 01:39:33PM +0200, lu_zero wrote:
> > 
> > Log:
> > Sanitize altivec code so it can be built with runtime check properly
> 
> You ignored most of my review.  Neither did you split off the parts
> that could be committed separately nor did you properly do the Makefile
> parts.
> 
> > --- trunk/libavcodec/Makefile	(original)
> > +++ trunk/libavcodec/Makefile	Tue Oct  2 13:39:32 2007
> > @@ -403,7 +403,7 @@ OBJS-$(ARCH_SH4)                       +
> >  
> > -OBJS-$(HAVE_ALTIVEC)                   += ppc/dsputil_altivec.o      \
> > +ALTIVEC-OBJS-yes                       += ppc/dsputil_altivec.o      \
> >                                            ppc/fdct_altivec.o         \
> >                                            ppc/fft_altivec.o          \
> >                                            ppc/float_altivec.o        \
> > @@ -413,12 +413,17 @@ OBJS-$(HAVE_ALTIVEC)                   +
> >                                            ppc/mpegvideo_altivec.o    \
> >                                            ppc/mpegvideo_ppc.o        \
> >  
> > -ifeq ($(HAVE_ALTIVEC),yes)
> > -OBJS-$(CONFIG_H264_DECODER)            += ppc/h264_altivec.o
> > -OBJS-$(CONFIG_SNOW_DECODER)            += ppc/snow_altivec.o
> > -OBJS-$(CONFIG_VC1_DECODER)             += ppc/vc1dsp_altivec.o
> > -OBJS-$(CONFIG_WMV3_DECODER)            += ppc/vc1dsp_altivec.o
> > -endif
> > +ALTIVEC-OBJS-$(CONFIG_H264_DECODER)    += ppc/h264_altivec.o
> > +ALTIVEC-OBJS-$(CONFIG_SNOW_DECODER)    += ppc/snow_altivec.o
> > +ALTIVEC-OBJS-$(CONFIG_VC1_DECODER)     += ppc/vc1dsp_altivec.o
> > +ALTIVEC-OBJS-$(CONFIG_WMV3_DECODER)    += ppc/vc1dsp_altivec.o
> > +
> > +# -maltivec is needed in order to build AltiVec code.
> > +$(ALTIVEC-OBJS-yes): CFLAGS += -maltivec -mabi=altivec
> > +
> > +# check_altivec must be built without -maltivec
> > +OBJS-$(HAVE_ALTIVEC)                   += $(ALTIVEC-OBJS-yes)       \
> > +                                          ppc/check_altivec.o
> 
> This is ugly and needlessly intrusive.  Fix it properly or revert it.

Hmm... did anything happen on that?