[FFmpeg-cvslog] r10500 - trunk/libavcodec/vc1.c

[Måns Rullgård]

Mike Melanson <mike at multimedia.cx> writes:

> M?ns Rullg?rd wrote:
>> Mike Melanson <mike at multimedia.cx> writes:
>> 
>>> Benoit Fouet wrote:
>>>> kostya wrote:
>>>>> Author: kostya
>>>>> Date: Sat Sep 15 11:24:53 2007
>>>>> New Revision: 10500
>>>>>
>>>>> Log:
>>>>> HALFPQ should be used only for when PQUANT is selected
>>>>>
>>>>> Modified:
>>>>>    trunk/libavcodec/vc1.c
>>>>>
>>>>> Modified: trunk/libavcodec/vc1.c
>>>>> ==============================================================================
>>>>> --- trunk/libavcodec/vc1.c	(original)
>>>>> +++ trunk/libavcodec/vc1.c	Sat Sep 15 11:24:53 2007
>>>>> @@ -2562,7 +2562,7 @@ static int vc1_decode_i_block_adv(VC1Con
>>>>>      ac_val = s->ac_val[0][0] + s->block_index[n] * 16;
>>>>>      ac_val2 = ac_val;
>>>>>  
>>>>> -    scale = mquant * 2 + v->halfpq;
>>>>> +    scale = mquant * 2 + ((mquant == v->pq) ? v->halfpq : 0);
>>>>>   
>>>> unneeded parentheses around ==
>>> It's more readable that way.
>> 
>> Which way?  Without the useless parens is more readable, I'd say.
>
> You're certainly entitled to your opinion, wrong though it may be.

Didn't I say that some time or other?

-- 
M?ns Rullg?rd
mans at mansr.com