[FFmpeg-cvslog] r12871 - trunk/libavcodec/alac.c

Michael Niedermayer michaelni
Thu Apr 17 21:41:08 CEST 2008

On Thu, Apr 17, 2008 at 08:59:45PM +0200, Vitor Sessak wrote:
> Michael Niedermayer wrote:
>> On Thu, Apr 17, 2008 at 08:20:25PM +0200, Vitor Sessak wrote:
>>> Vitor Sessak wrote:
>>>> michael wrote:
>>>>> Author: michael
>>>>> Date: Thu Apr 17 04:40:50 2008
>>>>> New Revision: 12871
>>>>> Log:
>>>>> more senseless code
>>>>> One wonders how such stuff gets past the reviews ...
>>>> I suppose that you remember that one year ago, the main decoding loop 
>>>> was triplicated (!): once for mono and once for each stereo channel.
>> no i dont remember, which commit was that exactly?
> It was 9576, 9724-9727. Also there was an av_log2() reimplementation 
> removed in 9735.

ok, now i faintly remember, still how did this messy decoder reach svn
in the first place?

>>>> Well, since you are at it, the attached patch removes a unneeded wrapper 
>>>> around av_log2().
>>> Oops, I missed an obvious simplification. This one is better.
>> ok
> Commited. Now this one removes some unneeded vars.

ok and just commit such cleanups directly, no need to post patches

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080417/dfaeb422/attachment.pgp>

More information about the ffmpeg-cvslog mailing list