[FFmpeg-cvslog] r14484 - in trunk/libavcodec: audioconvert.c audioconvert.h

[Michael Niedermayer]

On Fri, Aug 01, 2008 at 04:50:07PM +0100, M?ns Rullg?rd wrote:
> 
> Michael Niedermayer wrote:
> > On Fri, Aug 01, 2008 at 02:12:21PM +0100, M?ns Rullg?rd wrote:
> >>
> >> Michael Niedermayer wrote:
> >> > On Fri, Aug 01, 2008 at 09:39:16AM +0100, M?ns Rullg?rd wrote:
> >> >> Michael Niedermayer <michaelni at gmx.at> writes:
> >> >>
> >> >> > The only reason why its not causing a problem is plain because its not
> >> >> > done, our headers luckily do in general not include all the headers
> >> they
> >> >> > somehow depend on.
> >> >>
> >> >> Actually, *all* our headers #include their dependencies.  That's what
> >> >> "make checkheaders" makes sure.
> >> >
> >> > avcodec.h does not include inttypes or stdint directly but use int64_t
> >> > and iam sure it would be easier to find headers missing dependencies
> >> > than ones listing all.
> >>
> >> avcodec.h includes common.h, which does include stdint.h.  As I said,
> >
> > no, avcodec.h does not directly include common.h
> > it includes avutil.h that includes common.h which includes inttypes.h
> >
> > Its kinda ironic that you know the header inclusion chains we have nowadays
> > as well as i aka not at all. (without RTFS of course, anyone can figure it
> > out by RTFS ...)
> 
> The exact chains are irrelevant, and that's the point.  If every header
> provides, in one way or another, everything it requires, there is no
> need to be concerned with the exact details.

Then please explain me what you meant in your mail that said:
"
    It should not be committed at all.  Files should #include all headers they
    explicitly depend on.  The only exceptions to this rule are common.h and
    internal.h.

    Please revert this.
"

avcodec.h is included by audioconvert.h so removial of #include avcodec.h
still has it included "one way or another"

Do you want every file to directly and litterally include all headers it
depends on or is it ok to include another header that somehow causes all
dependancies to be included? There is a big difference between these 2


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-cvslog/attachments/20080801/6e3a42ba/attachment.pgp>