[FFmpeg-cvslog] r14484 - in trunk/libavcodec: audioconvert.c audioconvert.h

[Robert Swain]

2008/8/3 Michael Niedermayer <michaelni at gmx.at>:
> On Sun, Aug 03, 2008 at 01:55:50PM +0100, M?ns Rullg?rd wrote:
>> The Wanderer <inverseparadox at comcast.net> writes:
>> > Diego Biurrun wrote:
>> >> On Sat, Aug 02, 2008 at 02:55:30PM +0200, Diego Biurrun wrote:
>> >>> On Sat, Aug 02, 2008 at 12:12:11AM +0200, Michael Niedermayer
>> >>> wrote:
>> >>>
>> >>>> Would it be possible that you could spell out the rule you think
>> >>>> is a rule so we all know beyond doubt if there are exceptions and
>> >>>> if so which exactly.
>> >>>
>> >>> All files should #include everything they need directly.
>> >>
>> >> For system headers like inttypes.h that are documented to always
>> >> #include other headers like stdint.h, I consider just inttypes.h
>> >> enough.
>> >
>> > What about for non-system headers which are, or could be, "documented"
>> > (that is, explicitly guaranteed) to always include particular other
>> > headers - or, more to the point, provide particular symbols?
>>
>> Same thing.  Let me try to state exactly what I want the rule to be:
>>
>>   For each type, symbol, or macro used in a file (source or header),
>>   the file shall contain an #include line guaranteed to provide,
>>   directly or indirectly, a declaration or definition of the type,
>>   symbol, or macro.
>>
>> Is this unambiguous enough?
>
> Yes, thank you!
>
> I do not want to make a premature statement but i think this suggestion
> would be acceptable.

Sounds good and sensible to me.

Rob