[FFmpeg-cvslog] r11815 - trunk/libavformat/asf.c

[Diego Biurrun]

On Sat, Feb 02, 2008 at 04:46:27PM -0500, Rich Felker wrote:
> On Sat, Feb 02, 2008 at 10:25:35PM +0100, Michael Niedermayer wrote:
> > On Sat, Feb 02, 2008 at 10:17:46PM +0100, reimar wrote:
> > > 
> > > Log:
> > > Put is_mms under ifdef CONFIG_MMSH_PROTOCOL, avoids warning:
> > > libavformat/asf.c:112: warning: 'is_mms' defined but not used
> > 
> > Iam not too much in favor of these kind of warning fixes ...
> 
> Agree. cost(#ifdef) >> cost(warning) (and here >> means greater by an
> order of magnitude, not rightshift).

I disagree, that #ifdef is pretty harmless IMO.

Diego