[FFmpeg-cvslog] r11883 - trunk/libavcodec/vorbis.c

[Balatoni Denes]

Hi!

Sunday 10 February 2008 18:23-kor Loren Merritt ezt ?rta:
> Now I can't see how the check (as written) can ever matter. The value of
> samples passed into render_list is vf->list[1].x, i.e. the coordinate of
> the last point on the curve. This has been the case ever since the vorbis
> decoder was first written in r4261 (2005-05-17).
> The value that x should be checked against is [n] aka blocksize. 

Indeed, it has always been broken - and I have not noticed it before.

> Except 
> that a branch in an inner loop isn't the right fix, instead just allocate
> a big enough buffer for floor1 that it fits.

As Michael always says: patch welcome.

> So my commit would have been a regression if Oded's bug was ever fixed.
> But it wasn't fixed, so my commit didn't change any behaviour.

Seems so (and now it's also clear to me that the FFMIN is also not actually 
needed, since the floor x coordinates will always be less than or equal to 
vf->list[1].x).

> --Loren Merritt

bye
Denes