[FFmpeg-cvslog] r11694 - trunk/libavcodec/h263.c

[Rich Felker]

On Mon, Feb 11, 2008 at 05:26:42AM +0100, Michael Niedermayer wrote:
> On Fri, Feb 01, 2008 at 12:15:30AM +0100, Aurelien Jacobs wrote:
> > michael wrote:
> > 
> > > Author: michael
> > > Date: Thu Jan 31 15:01:33 2008
> > > New Revision: 11694
> > > 
> > > Log:
> > > Revert r11689 and r11690 (uninitalized warning fix) as its
> > > theoretically undefined in C.
> > 
> > Probably time for me to resort one of my old patch (attached).
> > int x=x; is theoretically undefined in C, but it's well defined
> > when compiling with gcc.
> > Is this an acceptable compromise ?
> 
> such code makes ffmpeg harder to understand for non ffmpeg developers
> so iam against it
> if it had a name at least which wouldnt require the reader to look the
> code up ...

Also think of the ugly confusion of declaring pointers..

char *av_uninitialized(foo);

I'm against uglifying the code for the sake of eliminating idiotic
warnings. gcc should just provide a way to disable this bogus warning.
If it doesn't already provide one (without also disabling valid
warnings), file a bug report...

Rich