[FFmpeg-cvslog] r11962 - trunk/libavcodec/utils.c

[Vitor Sessak]

Hi,

Uoti Urpala wrote:
> On Fri, 2008-02-15 at 21:23 +0100, vitor wrote:
>> Author: vitor
>> Date: Fri Feb 15 21:23:49 2008
>> New Revision: 11962
>>
>> Log:
>> Simplify avcodec_default_get_buffer()
> 
> 
>> +        tmpsize = ff_fill_pointer(&picture, NULL, s->pix_fmt, h);
>> +
>> +        for (i=0; i<3 && picture.data[i+1]; i++)
>> +            size[i] = picture.data[i+1] - picture.data[i];
>> +        size[i] = tmpsize - size[i];
> 
> And another bug in this commit: since size[i] wasn't set yet, the last
> line sets size[i] equal to the size of ALL the planes. This should
> probably be something like
>         size[i] = tmpsize - (picture.data[i] - picture.data[0]);

I agree with both of your comments, thanks for catching that. 1000l. But 
I'm leaving the town in a few minutes, so if you want to fix it 
yourself, I'll be glad. If not, I'll fix it as soon as I get back.

-Vitor