[FFmpeg-cvslog] r12217 - trunk/libavutil/mem.h

[Rich Felker]

On Mon, Feb 25, 2008 at 07:59:48PM +0100, Reimar D?ffinger wrote:
> On Mon, Feb 25, 2008 at 07:25:49PM +0100, michael wrote:
> > Author: michael
> > Date: Mon Feb 25 19:25:49 2008
> > New Revision: 12217
> > 
> > Log:
> > Make code C conformant.
> > 
> > 
> > Modified:
> >    trunk/libavutil/mem.h
> > 
> > Modified: trunk/libavutil/mem.h
> > ==============================================================================
> > --- trunk/libavutil/mem.h	(original)
> > +++ trunk/libavutil/mem.h	Mon Feb 25 19:25:49 2008
> > @@ -36,7 +36,7 @@
> >      #define DECLARE_ALIGNED(n,t,v)      __declspec(align(n)) t v
> >      #define DECLARE_ASM_CONST(n,t,v)    __declspec(align(n)) static const t v
> >  #else
> > -    #warning No align and asm directives, this might fail.
> > +//  #warning No align and asm directives, this might fail.
> >      #define DECLARE_ALIGNED(n,t,v)      t v
> >      #define DECLARE_ASM_CONST(n,t,v)    static const t v
> 
> Well, so we finally end up where I feared: Creating broken code by
> default without even a warning at least on some compilers (_if_ it would
> finally manage to compile FFmpeg code, at least Sun C one).

Then write and apply the fixes I suggested to configure: detect the
capability to compile asm, and make sure that no asm is compiled
whenever this default case is used!! Then there is NEVER
broken-by-default code because the default will always be plain C when
a supported platform/compiler for asm is not detected.

Rich