[FFmpeg-cvslog] r12241 - trunk/libavformat/mov.c

Måns Rullgård mans
Tue Feb 26 20:18:54 CET 2008


Reimar D?ffinger <Reimar.Doeffinger at stud.uni-karlsruhe.de> writes:

> On Tue, Feb 26, 2008 at 07:50:14PM +0100, Baptiste Coudurier wrote:
>> Reimar D?ffinger wrote:
>> >> @@ -1451,6 +1529,13 @@ static int mov_read_header(AVFormatConte
>> >>          sc->ffindex = i;
>> >>          mov_build_index(mov, st);
>> >>  
>> >> +        if (sc->dref_id-1 < sc->drefs_count && sc->drefs[sc->dref_id-1].path) {
>> >> +            if (url_fopen(&sc->pb, sc->drefs[sc->dref_id-1].path, URL_RDONLY) < 0)
>> >> +                av_log(s, AV_LOG_ERROR, "stream %d, error opening external essence: %s\n",
>> >> +                       st->index, strerror(errno));
>> >> +        } else
>> >> +            sc->pb = s->pb;
>> > 
>> > This must be a joke. Or do you seriously consider it acceptable for a
>> > demuxer to do url_fopen?!
>> 
>> Please do not whine. Give valid reasons AND suggest another correct way
>> to handle those files.
>
> And oh, I _will_ whine, IMHO this was the worst idea implemented in
> FFmpeg since years, you may disagree but I feel entitle to whine about
> _this_.

I'll readily admit it is one of the worst ideas ever to include such
features in the spec.  Given that it's in the spec, I don't think it's
fair to call implementing it a bad idea (assuming there are files that
actually use it).  That said, I agree with your security/privacy
concerns.

When you're done whining, perhaps you could help think of a proper
solution to handle situations like this.

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-cvslog mailing list